From 0c8f10f6b54f539331e5bc159415b0756ebe07c5 Mon Sep 17 00:00:00 2001 From: Mathieu Date: Thu, 18 Apr 2024 11:25:59 +0200 Subject: [PATCH] fix: add return types for all methods --- Behavioral/State/ContextOrder.php | 6 +++--- Behavioral/State/CreateOrder.php | 2 +- Behavioral/State/OrderDone.php | 2 +- Behavioral/State/ShippingOrder.php | 2 +- Behavioral/State/StateOrder.php | 2 +- Behavioral/State/Tests/StateTest.php | 8 ++++---- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Behavioral/State/ContextOrder.php b/Behavioral/State/ContextOrder.php index 76e5631..3b64440 100644 --- a/Behavioral/State/ContextOrder.php +++ b/Behavioral/State/ContextOrder.php @@ -16,17 +16,17 @@ class ContextOrder return $order; } - public function setState(StateOrder $state) + public function setState(StateOrder $state): void { $this->state = $state; } - public function proceedToNext() + public function proceedToNext(): void { $this->state->proceedToNext($this); } - public function toString() + public function toString(): string { return $this->state->toString(); } diff --git a/Behavioral/State/CreateOrder.php b/Behavioral/State/CreateOrder.php index a72711c..1385871 100644 --- a/Behavioral/State/CreateOrder.php +++ b/Behavioral/State/CreateOrder.php @@ -6,7 +6,7 @@ namespace DesignPatterns\Behavioral\State; class CreateOrder implements StateOrder { - public function proceedToNext(ContextOrder $context) + public function proceedToNext(ContextOrder $context): void { $context->setState(new ShippingOrder()); } diff --git a/Behavioral/State/OrderDone.php b/Behavioral/State/OrderDone.php index e7c596f..5f1a3f7 100644 --- a/Behavioral/State/OrderDone.php +++ b/Behavioral/State/OrderDone.php @@ -6,7 +6,7 @@ namespace DesignPatterns\Behavioral\State; class OrderDone implements StateOrder { - public function proceedToNext(ContextOrder $context) + public function proceedToNext(ContextOrder $context): void { // there is nothing more to do } diff --git a/Behavioral/State/ShippingOrder.php b/Behavioral/State/ShippingOrder.php index 6ad0256..d82591d 100644 --- a/Behavioral/State/ShippingOrder.php +++ b/Behavioral/State/ShippingOrder.php @@ -6,7 +6,7 @@ namespace DesignPatterns\Behavioral\State; class ShippingOrder implements StateOrder { - public function proceedToNext(ContextOrder $context) + public function proceedToNext(ContextOrder $context): void { $context->setState(new OrderDone()); } diff --git a/Behavioral/State/StateOrder.php b/Behavioral/State/StateOrder.php index eeb9021..1847158 100644 --- a/Behavioral/State/StateOrder.php +++ b/Behavioral/State/StateOrder.php @@ -6,7 +6,7 @@ namespace DesignPatterns\Behavioral\State; interface StateOrder { - public function proceedToNext(ContextOrder $context); + public function proceedToNext(ContextOrder $context): void; public function toString(): string; } diff --git a/Behavioral/State/Tests/StateTest.php b/Behavioral/State/Tests/StateTest.php index d357e83..2b668e2 100644 --- a/Behavioral/State/Tests/StateTest.php +++ b/Behavioral/State/Tests/StateTest.php @@ -9,14 +9,14 @@ use PHPUnit\Framework\TestCase; class StateTest extends TestCase { - public function testIsCreatedWithStateCreated() + public function testIsCreatedWithStateCreated(): void { $orderContext = ContextOrder::create(); $this->assertSame('created', $orderContext->toString()); } - public function testCanProceedToStateShipped() + public function testCanProceedToStateShipped(): void { $contextOrder = ContextOrder::create(); $contextOrder->proceedToNext(); @@ -24,7 +24,7 @@ class StateTest extends TestCase $this->assertSame('shipped', $contextOrder->toString()); } - public function testCanProceedToStateDone() + public function testCanProceedToStateDone(): void { $contextOrder = ContextOrder::create(); $contextOrder->proceedToNext(); @@ -33,7 +33,7 @@ class StateTest extends TestCase $this->assertSame('done', $contextOrder->toString()); } - public function testStateDoneIsTheLastPossibleState() + public function testStateDoneIsTheLastPossibleState(): void { $contextOrder = ContextOrder::create(); $contextOrder->proceedToNext();