info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-08-03 13:37:27 +02:00
Code Issues Projects Releases Wiki Activity

Use class constant instead of hardcoded namespace

Browse Source
This commit is contained in:
Fabri Di Napoli
2017-03-09 00:14:31 +01:00
parent eb3b8529b6
commit 10ee886fe1
10 changed files with 30 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Creational/AbstractFactory/Tests/AbstractFactoryTest.php
View File

@@ -3,7 +3,9 @@
namespace DesignPatterns\Creational\AbstractFactory\Tests; namespace DesignPatterns\Creational\AbstractFactory\Tests;
use DesignPatterns\Creational\AbstractFactory\HtmlFactory; use DesignPatterns\Creational\AbstractFactory\HtmlFactory;
use DesignPatterns\Creational\AbstractFactory\HtmlText;
use DesignPatterns\Creational\AbstractFactory\JsonFactory; use DesignPatterns\Creational\AbstractFactory\JsonFactory;
use DesignPatterns\Creational\AbstractFactory\JsonText;
class AbstractFactoryTest extends \PHPUnit_Framework_TestCase class AbstractFactoryTest extends \PHPUnit_Framework_TestCase
{ {
@@ -12,7 +14,7 @@ class AbstractFactoryTest extends \PHPUnit_Framework_TestCase
$factory = new HtmlFactory(); $factory = new HtmlFactory();
$text = $factory->createText('foobar'); $text = $factory->createText('foobar');
$this->assertInstanceOf('DesignPatterns\Creational\AbstractFactory\HtmlText', $text); $this->assertInstanceOf(HtmlText::class, $text);
} }
public function testCanCreateJsonText() public function testCanCreateJsonText()
@@ -20,6 +22,6 @@ class AbstractFactoryTest extends \PHPUnit_Framework_TestCase
$factory = new JsonFactory(); $factory = new JsonFactory();
$text = $factory->createText('foobar'); $text = $factory->createText('foobar');
$this->assertInstanceOf('DesignPatterns\Creational\AbstractFactory\JsonText', $text); $this->assertInstanceOf(JsonText::class, $text);
} }
} }

6
Creational/Builder/Tests/DirectorTest.php
View File

@@ -2,6 +2,8 @@
namespace DesignPatterns\Creational\Builder\Tests; namespace DesignPatterns\Creational\Builder\Tests;
use DesignPatterns\Creational\Builder\Parts\Car;
use DesignPatterns\Creational\Builder\Parts\Truck;
use DesignPatterns\Creational\Builder\TruckBuilder; use DesignPatterns\Creational\Builder\TruckBuilder;
use DesignPatterns\Creational\Builder\CarBuilder; use DesignPatterns\Creational\Builder\CarBuilder;
use DesignPatterns\Creational\Builder\Director; use DesignPatterns\Creational\Builder\Director;
@@ -13,7 +15,7 @@ class DirectorTest extends \PHPUnit_Framework_TestCase
$truckBuilder = new TruckBuilder(); $truckBuilder = new TruckBuilder();
$newVehicle = (new Director())->build($truckBuilder); $newVehicle = (new Director())->build($truckBuilder);
$this->assertInstanceOf('DesignPatterns\Creational\Builder\Parts\Truck', $newVehicle); $this->assertInstanceOf(Truck::class, $newVehicle);
} }
public function testCanBuildCar() public function testCanBuildCar()
@@ -21,6 +23,6 @@ class DirectorTest extends \PHPUnit_Framework_TestCase
$carBuilder = new CarBuilder(); $carBuilder = new CarBuilder();
$newVehicle = (new Director())->build($carBuilder); $newVehicle = (new Director())->build($carBuilder);
$this->assertInstanceOf('DesignPatterns\Creational\Builder\Parts\Car', $newVehicle); $this->assertInstanceOf(Car::class, $newVehicle);
} }
} }

11
Creational/FactoryMethod/Tests/FactoryMethodTest.php
View File

@@ -2,6 +2,9 @@
namespace DesignPatterns\Creational\FactoryMethod\Tests; namespace DesignPatterns\Creational\FactoryMethod\Tests;
use DesignPatterns\Creational\FactoryMethod\Bicycle;
use DesignPatterns\Creational\FactoryMethod\CarFerrari;
use DesignPatterns\Creational\FactoryMethod\CarMercedes;
use DesignPatterns\Creational\FactoryMethod\FactoryMethod; use DesignPatterns\Creational\FactoryMethod\FactoryMethod;
use DesignPatterns\Creational\FactoryMethod\GermanFactory; use DesignPatterns\Creational\FactoryMethod\GermanFactory;
use DesignPatterns\Creational\FactoryMethod\ItalianFactory; use DesignPatterns\Creational\FactoryMethod\ItalianFactory;
@@ -13,7 +16,7 @@ class FactoryMethodTest extends \PHPUnit_Framework_TestCase
$factory = new GermanFactory(); $factory = new GermanFactory();
$result = $factory->create(FactoryMethod::CHEAP); $result = $factory->create(FactoryMethod::CHEAP);
$this->assertInstanceOf('DesignPatterns\Creational\FactoryMethod\Bicycle', $result); $this->assertInstanceOf(Bicycle::class, $result);
} }
public function testCanCreateFastVehicleInGermany() public function testCanCreateFastVehicleInGermany()
@@ -21,7 +24,7 @@ class FactoryMethodTest extends \PHPUnit_Framework_TestCase
$factory = new GermanFactory(); $factory = new GermanFactory();
$result = $factory->create(FactoryMethod::FAST); $result = $factory->create(FactoryMethod::FAST);
$this->assertInstanceOf('DesignPatterns\Creational\FactoryMethod\CarMercedes', $result); $this->assertInstanceOf(CarMercedes::class, $result);
} }
public function testCanCreateCheapVehicleInItaly() public function testCanCreateCheapVehicleInItaly()
@@ -29,7 +32,7 @@ class FactoryMethodTest extends \PHPUnit_Framework_TestCase
$factory = new ItalianFactory(); $factory = new ItalianFactory();
$result = $factory->create(FactoryMethod::CHEAP); $result = $factory->create(FactoryMethod::CHEAP);
$this->assertInstanceOf('DesignPatterns\Creational\FactoryMethod\Bicycle', $result); $this->assertInstanceOf(Bicycle::class, $result);
} }
public function testCanCreateFastVehicleInItaly() public function testCanCreateFastVehicleInItaly()
@@ -37,7 +40,7 @@ class FactoryMethodTest extends \PHPUnit_Framework_TestCase
$factory = new ItalianFactory(); $factory = new ItalianFactory();
$result = $factory->create(FactoryMethod::FAST); $result = $factory->create(FactoryMethod::FAST);
$this->assertInstanceOf('DesignPatterns\Creational\FactoryMethod\CarFerrari', $result); $this->assertInstanceOf(CarFerrari::class, $result);
} }
/** /**

6
Creational/Multiton/Tests/MultitonTest.php
View File

@@ -11,7 +11,7 @@ class MultitonTest extends \PHPUnit_Framework_TestCase
$firstCall = Multiton::getInstance(Multiton::INSTANCE_1); $firstCall = Multiton::getInstance(Multiton::INSTANCE_1);
$secondCall = Multiton::getInstance(Multiton::INSTANCE_1); $secondCall = Multiton::getInstance(Multiton::INSTANCE_1);
$this->assertInstanceOf('DesignPatterns\Creational\Multiton\Multiton', $firstCall); $this->assertInstanceOf(Multiton::class, $firstCall);
$this->assertSame($firstCall, $secondCall); $this->assertSame($firstCall, $secondCall);
} }
@@ -20,8 +20,8 @@ class MultitonTest extends \PHPUnit_Framework_TestCase
$firstCall = Multiton::getInstance(Multiton::INSTANCE_1); $firstCall = Multiton::getInstance(Multiton::INSTANCE_1);
$secondCall = Multiton::getInstance(Multiton::INSTANCE_2); $secondCall = Multiton::getInstance(Multiton::INSTANCE_2);
$this->assertInstanceOf('DesignPatterns\Creational\Multiton\Multiton', $firstCall); $this->assertInstanceOf(Multiton::class, $firstCall);
$this->assertInstanceOf('DesignPatterns\Creational\Multiton\Multiton', $secondCall); $this->assertInstanceOf(Multiton::class, $secondCall);
$this->assertNotSame($firstCall, $secondCall); $this->assertNotSame($firstCall, $secondCall);
} }
} }

4
Creational/Prototype/Tests/PrototypeTest.php
View File

@@ -15,13 +15,13 @@ class PrototypeTest extends \PHPUnit_Framework_TestCase
for ($i = 0; $i < 10; $i++) { for ($i = 0; $i < 10; $i++) {
$book = clone $fooPrototype; $book = clone $fooPrototype;
$book->setTitle('Foo Book No ' . $i); $book->setTitle('Foo Book No ' . $i);
$this->assertInstanceOf('DesignPatterns\Creational\Prototype\FooBookPrototype', $book); $this->assertInstanceOf(FooBookPrototype::class, $book);
} }
for ($i = 0; $i < 5; $i++) { for ($i = 0; $i < 5; $i++) {
$book = clone $barPrototype; $book = clone $barPrototype;
$book->setTitle('Bar Book No ' . $i); $book->setTitle('Bar Book No ' . $i);
$this->assertInstanceOf('DesignPatterns\Creational\Prototype\BarBookPrototype', $book); $this->assertInstanceOf(BarBookPrototype::class, $book);
} }
} }
} }

3
Creational/SimpleFactory/Tests/SimpleFactoryTest.php
View File

@@ -2,6 +2,7 @@
namespace DesignPatterns\Creational\SimpleFactory\Tests; namespace DesignPatterns\Creational\SimpleFactory\Tests;
use DesignPatterns\Creational\SimpleFactory\Bicycle;
use DesignPatterns\Creational\SimpleFactory\SimpleFactory; use DesignPatterns\Creational\SimpleFactory\SimpleFactory;
class SimpleFactoryTest extends \PHPUnit_Framework_TestCase class SimpleFactoryTest extends \PHPUnit_Framework_TestCase
@@ -9,6 +10,6 @@ class SimpleFactoryTest extends \PHPUnit_Framework_TestCase
public function testCanCreateBicycle() public function testCanCreateBicycle()
{ {
$bicycle = (new SimpleFactory())->createBicycle(); $bicycle = (new SimpleFactory())->createBicycle();
$this->assertInstanceOf('DesignPatterns\Creational\SimpleFactory\Bicycle', $bicycle); $this->assertInstanceOf(Bicycle::class, $bicycle);
} }
} }

2
Creational/Singleton/Tests/SingletonTest.php
View File

@@ -11,7 +11,7 @@ class SingletonTest extends \PHPUnit_Framework_TestCase
$firstCall = Singleton::getInstance(); $firstCall = Singleton::getInstance();
$secondCall = Singleton::getInstance(); $secondCall = Singleton::getInstance();
$this->assertInstanceOf('DesignPatterns\Creational\Singleton\Singleton', $firstCall); $this->assertInstanceOf(Singleton::class, $firstCall);
$this->assertSame($firstCall, $secondCall); $this->assertSame($firstCall, $secondCall);
} }
} }

2
More/ServiceLocator/Tests/ServiceLocatorTest.php
View File

@@ -31,6 +31,6 @@ class ServiceLocatorTest extends TestCase
$this->serviceLocator->addClass(LogService::class, []); $this->serviceLocator->addClass(LogService::class, []);
$logger = $this->serviceLocator->get(LogService::class); $logger = $this->serviceLocator->get(LogService::class);
$this->assertInstanceOf('DesignPatterns\More\ServiceLocator\LogService', $logger); $this->assertInstanceOf(LogService::class, $logger);
} }
} }

3
Structural/DataMapper/Tests/DataMapperTest.php
View File

@@ -3,6 +3,7 @@
namespace DesignPatterns\Structural\DataMapper\Tests; namespace DesignPatterns\Structural\DataMapper\Tests;
use DesignPatterns\Structural\DataMapper\StorageAdapter; use DesignPatterns\Structural\DataMapper\StorageAdapter;
use DesignPatterns\Structural\DataMapper\User;
use DesignPatterns\Structural\DataMapper\UserMapper; use DesignPatterns\Structural\DataMapper\UserMapper;
class DataMapperTest extends \PHPUnit_Framework_TestCase class DataMapperTest extends \PHPUnit_Framework_TestCase
@@ -14,7 +15,7 @@ class DataMapperTest extends \PHPUnit_Framework_TestCase
$user = $mapper->findById(1); $user = $mapper->findById(1);
$this->assertInstanceOf('DesignPatterns\Structural\DataMapper\User', $user); $this->assertInstanceOf(User::class, $user);
} }
/** /**

7
Structural/Registry/Tests/RegistryTest.php
View File

@@ -3,19 +3,20 @@
namespace DesignPatterns\Structural\Registry\Tests; namespace DesignPatterns\Structural\Registry\Tests;
use DesignPatterns\Structural\Registry\Registry; use DesignPatterns\Structural\Registry\Registry;
use stdClass;
class RegistryTest extends \PHPUnit_Framework_TestCase class RegistryTest extends \PHPUnit_Framework_TestCase
{ {
public function testSetAndGetLogger() public function testSetAndGetLogger()
{ {
$key = Registry::LOGGER; $key = Registry::LOGGER;
$logger = new \stdClass(); $logger = new stdClass();
Registry::set($key, $logger); Registry::set($key, $logger);
$storedLogger = Registry::get($key); $storedLogger = Registry::get($key);
$this->assertSame($logger, $storedLogger); $this->assertSame($logger, $storedLogger);
$this->assertInstanceOf('stdClass', $storedLogger); $this->assertInstanceOf(stdClass::class, $storedLogger);
} }
/** /**
@@ -23,7 +24,7 @@ class RegistryTest extends \PHPUnit_Framework_TestCase
*/ */
public function testThrowsExceptionWhenTryingToSetInvalidKey() public function testThrowsExceptionWhenTryingToSetInvalidKey()
{ {
Registry::set('foobar', new \stdClass()); Registry::set('foobar', new stdClass());
} }
/** /**