info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-08-01 20:50:15 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #192 from marius-rizac/fixed-wrong-singleton-pattern

Browse Source 
Fixed wrong implementation of Singleton Pattern
This commit is contained in:
Dominik Liebler
2015-12-18 10:17:55 +01:00
parent f36bdcad9c df060dab97
commit 2c655a5cba
3 changed files with 37 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Creational/Singleton/Singleton.php
View File

@@ -2,6 +2,8 @@
namespace DesignPatterns\Creational\Singleton; namespace DesignPatterns\Creational\Singleton;
use DesignPatterns\Creational\Singleton\SingletonPatternViolationException;
/** /**
* class Singleton * class Singleton
*/ */
@@ -36,19 +38,21 @@ class Singleton
/** /**
* prevent the instance from being cloned * prevent the instance from being cloned
* * @throws SingletonPatternViolationException
* @return void * @return void
*/ */
private function __clone() public final function __clone()
{ {
throw new SingletonPatternViolationException('This is a Singleton. Clone is forbidden');
} }
/** /**
* prevent from being unserialized * prevent from being unserialized
* * @throws SingletonPatternViolationException
* @return void * @return void
*/ */
private function __wakeup() public final function __wakeup()
{ {
throw new SingletonPatternViolationException('This is a Singleton. __wakeup usage is forbidden');
} }
} }

8
Creational/Singleton/SingletonPatternViolationException.php Normal file
View File

@@ -0,0 +1,8 @@
<?php
namespace DesignPatterns\Creational\Singleton;
class SingletonPatternViolationException extends \Exception
{
}

21
Creational/Singleton/Tests/SingletonTest.php
View File

@@ -26,4 +26,25 @@ class SingletonTest extends \PHPUnit_Framework_TestCase
$meth = $refl->getMethod('__construct'); $meth = $refl->getMethod('__construct');
$this->assertTrue($meth->isPrivate()); $this->assertTrue($meth->isPrivate());
} }
/**
* @expectedException \DesignPatterns\Creational\Singleton\SingletonPatternViolationException
* @return void
*/
public function testNoCloneAllowed()
{
$obj1 = Singleton::getInstance();
$obj2 = clone $obj1;
}
/**
* @expectedException \DesignPatterns\Creational\Singleton\SingletonPatternViolationException
* @return void
*/
public function testNoSerializationAllowed()
{
$obj1 = Singleton::getInstance();
$serialized = serialize($obj1);
$obj2 = unserialize($serialized);
}
} }