From 0e358b79d262eaf53cdcab64526e38456e62a319 Mon Sep 17 00:00:00 2001 From: Petr Jurasek Date: Mon, 21 Mar 2016 17:03:04 +0100 Subject: [PATCH 1/3] Typo Typo update --- Structural/Facade/BiosInterface.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Structural/Facade/BiosInterface.php b/Structural/Facade/BiosInterface.php index 823af04..2655e6f 100644 --- a/Structural/Facade/BiosInterface.php +++ b/Structural/Facade/BiosInterface.php @@ -3,29 +3,29 @@ namespace DesignPatterns\Structural\Facade; /** - * Class BiosInterface. + * Interface BiosInterface */ interface BiosInterface { /** - * execute the BIOS. + * execute the BIOS */ public function execute(); /** - * wait for halt. + * wait for halt */ public function waitForKeyPress(); /** - * launches the OS. + * launches the OS * * @param OsInterface $os */ public function launch(OsInterface $os); /** - * power down BIOS. + * power down BIOS */ public function powerDown(); } From 00c3903b2e88143357070665edaaa3cc11121025 Mon Sep 17 00:00:00 2001 From: Petr Jurasek Date: Thu, 24 Mar 2016 09:45:55 +0100 Subject: [PATCH 2/3] Capitalize letters and add dots --- Structural/Facade/BiosInterface.php | 10 +++++----- Structural/Facade/Facade.php | 6 +++--- Structural/Facade/OsInterface.php | 4 ++-- Structural/Facade/Tests/FacadeTest.php | 2 ++ 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/Structural/Facade/BiosInterface.php b/Structural/Facade/BiosInterface.php index 2655e6f..8f1aa01 100644 --- a/Structural/Facade/BiosInterface.php +++ b/Structural/Facade/BiosInterface.php @@ -3,29 +3,29 @@ namespace DesignPatterns\Structural\Facade; /** - * Interface BiosInterface + * Interface BiosInterface. */ interface BiosInterface { /** - * execute the BIOS + * Execute the BIOS. */ public function execute(); /** - * wait for halt + * Wait for halt. */ public function waitForKeyPress(); /** - * launches the OS + * Launches the OS. * * @param OsInterface $os */ public function launch(OsInterface $os); /** - * power down BIOS + * Power down BIOS. */ public function powerDown(); } diff --git a/Structural/Facade/Facade.php b/Structural/Facade/Facade.php index 50c665d..6c96fea 100644 --- a/Structural/Facade/Facade.php +++ b/Structural/Facade/Facade.php @@ -3,7 +3,7 @@ namespace DesignPatterns\Structural\Facade; /** - * + * Class Facade */ class Facade { @@ -31,7 +31,7 @@ class Facade } /** - * turn on the system. + * Turn on the system. */ public function turnOn() { @@ -41,7 +41,7 @@ class Facade } /** - * turn off the system. + * Turn off the system. */ public function turnOff() { diff --git a/Structural/Facade/OsInterface.php b/Structural/Facade/OsInterface.php index 8394fd4..d8171e4 100644 --- a/Structural/Facade/OsInterface.php +++ b/Structural/Facade/OsInterface.php @@ -3,12 +3,12 @@ namespace DesignPatterns\Structural\Facade; /** - * Class OsInterface. + * Interface OsInterface. */ interface OsInterface { /** - * halt the OS. + * Halt the OS. */ public function halt(); } diff --git a/Structural/Facade/Tests/FacadeTest.php b/Structural/Facade/Tests/FacadeTest.php index e6038a0..0f1ea10 100644 --- a/Structural/Facade/Tests/FacadeTest.php +++ b/Structural/Facade/Tests/FacadeTest.php @@ -34,6 +34,8 @@ class FacadeTest extends \PHPUnit_Framework_TestCase } /** + * @param Computer $facade + * @param OsInterface $os * @dataProvider getComputer */ public function testComputerOn(Computer $facade, OsInterface $os) From 730316c11b2775c4c7f566b0431b9737bde4e32c Mon Sep 17 00:00:00 2001 From: Petr Jurasek Date: Thu, 24 Mar 2016 10:07:07 +0100 Subject: [PATCH 3/3] Add an dot --- Structural/Facade/Facade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Structural/Facade/Facade.php b/Structural/Facade/Facade.php index 6c96fea..43d1bcb 100644 --- a/Structural/Facade/Facade.php +++ b/Structural/Facade/Facade.php @@ -3,7 +3,7 @@ namespace DesignPatterns\Structural\Facade; /** - * Class Facade + * Class Facade. */ class Facade {