info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-07-29 19:20:18 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #123 from ftwbzhao/feature/iterator/booklist/remove

Browse Source 
fix booklist remove function
This commit is contained in:
Dominik Liebler
2015-03-08 18:06:29 +01:00
parent 12145c5605 53f4d364c0
commit 539f636427
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Behavioral/Iterator/BookList.php
View File

@@ -25,7 +25,7 @@ class BookList implements \Countable
public function removeBook(Book $bookToRemove) public function removeBook(Book $bookToRemove)
{ {
foreach ($this as $key => $book) { foreach ($this->books as $key => $book) {
/** @var Book $book */ /** @var Book $book */
if ($book->getAuthorAndTitle() === $bookToRemove->getAuthorAndTitle()) { if ($book->getAuthorAndTitle() === $bookToRemove->getAuthorAndTitle()) {
unset($this->books[$key]); unset($this->books[$key]);

9
Behavioral/Iterator/Tests/IteratorTest.php
View File

@@ -63,4 +63,13 @@ class IteratorTest extends \PHPUnit_Framework_TestCase
$iterator->next(); $iterator->next();
} }
} }
/**
* Test BookList Remove
*/
public function testBookRemove()
{
$this->bookList->removeBook($this->bookList->getBook(0));
$this->assertEquals($this->bookList->count(), 2);
}
} }