From 6e937055cf5f66ea9337f96e85b036626c699b79 Mon Sep 17 00:00:00 2001 From: Jan Brecka Date: Tue, 8 Apr 2014 11:29:03 +0200 Subject: [PATCH] unifies indentation --- Pool/Pool.php | 25 ++++++++++++------------- Pool/Processor.php | 1 - Pool/README.md | 1 - Pool/Worker.php | 7 +++---- Pool/index.php | 1 - 5 files changed, 15 insertions(+), 20 deletions(-) diff --git a/Pool/Pool.php b/Pool/Pool.php index a38da74..32de053 100644 --- a/Pool/Pool.php +++ b/Pool/Pool.php @@ -5,7 +5,7 @@ namespace DesignPatterns\Pool; class Pool { - private $instances = array(); + private $instances = array(); private $class; public function __construct($class) @@ -13,19 +13,18 @@ class Pool $this->class = $class; } - public function get() - { - if (count($this->instances) > 0) { - return array_pop($this->instances); - } + public function get() + { + if (count($this->instances) > 0) { + return array_pop($this->instances); + } - return new $this->class(); - } + return new $this->class(); + } - public function dispose($instance) - { - $this->instances[] = $instance; - } + public function dispose($instance) + { + $this->instances[] = $instance; + } } - diff --git a/Pool/Processor.php b/Pool/Processor.php index a3cac2d..eabd51d 100644 --- a/Pool/Processor.php +++ b/Pool/Processor.php @@ -51,4 +51,3 @@ class Processor } } - diff --git a/Pool/README.md b/Pool/README.md index b52fd87..a39c3b2 100644 --- a/Pool/README.md +++ b/Pool/README.md @@ -6,4 +6,3 @@ The **object pool pattern** is a software creational design pattern that uses a Object pooling can offer a significant performance boost in situations where the cost of initializing a class instance is high, the rate of instantiation of a class is high, and the number of instances in use at any one time is low. The pooled object is obtained in predictable time when creation of the new objects (especially over network) may take variable time. However these benefits are mostly true for objects that are expensive with respect to time, such as database connections, socket connections, threads and large graphic objects like fonts or bitmaps. In certain situations, simple object pooling (that hold no external resources, but only occupy memory) may not be efficient and could decrease performance. - diff --git a/Pool/Worker.php b/Pool/Worker.php index 8ef0f79..2eb4126 100644 --- a/Pool/Worker.php +++ b/Pool/Worker.php @@ -11,12 +11,11 @@ class Worker // for example creates "thread" } - public function run($image, array $callback) - { + public function run($image, array $callback) + { // do something with $image... // and when it's done, execute callback call_user_func($callback, $this); - } + } } - diff --git a/Pool/index.php b/Pool/index.php index a41c492..3059efe 100644 --- a/Pool/index.php +++ b/Pool/index.php @@ -14,4 +14,3 @@ $processor->process('image5.jpg'); $processor->process('image6.jpg'); $processor->process('image7.jpg'); $processor->process('image8.jpg'); -