From 6ec696d00b4873c1bf942149f5d46a33a34c4cee Mon Sep 17 00:00:00 2001
From: MathiasReker <mathias@reker.dk>
Date: Thu, 16 Jun 2022 21:09:49 +0200
Subject: [PATCH] Final public method for abstract class

All public methods of abstract classes should be final. Enforce API encapsulation in an inheritance architecture. If you want to override a method, use the Template method pattern.
---
 Behavioral/Mediator/Colleague.php      | 2 +-
 Behavioral/TemplateMethod/Journey.php  | 2 +-
 Creational/Builder/Parts/Vehicle.php   | 2 +-
 Creational/Prototype/BookPrototype.php | 4 ++--
 Structural/Bridge/Service.php          | 2 +-
 Structural/Registry/Registry.php       | 4 ++--
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Behavioral/Mediator/Colleague.php b/Behavioral/Mediator/Colleague.php
index 030bd45..a893347 100644
--- a/Behavioral/Mediator/Colleague.php
+++ b/Behavioral/Mediator/Colleague.php
@@ -8,7 +8,7 @@ abstract class Colleague
 {
     protected Mediator $mediator;
 
-    public function setMediator(Mediator $mediator)
+    final public function setMediator(Mediator $mediator)
     {
         $this->mediator = $mediator;
     }
diff --git a/Behavioral/TemplateMethod/Journey.php b/Behavioral/TemplateMethod/Journey.php
index 95d3521..bafce59 100644
--- a/Behavioral/TemplateMethod/Journey.php
+++ b/Behavioral/TemplateMethod/Journey.php
@@ -58,7 +58,7 @@ abstract class Journey
     /**
      * @return string[]
      */
-    public function getThingsToDo(): array
+    final public function getThingsToDo(): array
     {
         return $this->thingsToDo;
     }
diff --git a/Creational/Builder/Parts/Vehicle.php b/Creational/Builder/Parts/Vehicle.php
index 0cfb02c..b367384 100644
--- a/Creational/Builder/Parts/Vehicle.php
+++ b/Creational/Builder/Parts/Vehicle.php
@@ -6,7 +6,7 @@ namespace DesignPatterns\Creational\Builder\Parts;
 
 abstract class Vehicle
 {
-    public function setPart(string $key, object $value)
+    final public function setPart(string $key, object $value)
     {
     }
 }
diff --git a/Creational/Prototype/BookPrototype.php b/Creational/Prototype/BookPrototype.php
index ff7b8d9..0470edc 100644
--- a/Creational/Prototype/BookPrototype.php
+++ b/Creational/Prototype/BookPrototype.php
@@ -11,12 +11,12 @@ abstract class BookPrototype
 
     abstract public function __clone();
 
-    public function getTitle(): string
+    final public function getTitle(): string
     {
         return $this->title;
     }
 
-    public function setTitle(string $title): void
+    final public function setTitle(string $title): void
     {
         $this->title = $title;
     }
diff --git a/Structural/Bridge/Service.php b/Structural/Bridge/Service.php
index b077fb0..f03605a 100644
--- a/Structural/Bridge/Service.php
+++ b/Structural/Bridge/Service.php
@@ -10,7 +10,7 @@ abstract class Service
     {
     }
 
-    public function setImplementation(Formatter $printer)
+    final public function setImplementation(Formatter $printer)
     {
         $this->implementation = $printer;
     }
diff --git a/Structural/Registry/Registry.php b/Structural/Registry/Registry.php
index 84878a8..8593092 100644
--- a/Structural/Registry/Registry.php
+++ b/Structural/Registry/Registry.php
@@ -22,7 +22,7 @@ abstract class Registry
         self::LOGGER,
     ];
 
-    public static function set(string $key, Service $value)
+    final public static function set(string $key, Service $value)
     {
         if (!in_array($key, self::$allowedKeys)) {
             throw new InvalidArgumentException('Invalid key given');
@@ -31,7 +31,7 @@ abstract class Registry
         self::$services[$key] = $value;
     }
 
-    public static function get(string $key): Service
+    final public static function get(string $key): Service
     {
         if (!in_array($key, self::$allowedKeys) || !isset(self::$services[$key])) {
             throw new InvalidArgumentException('Invalid key given');