#226 fixed Builder

This commit is contained in:
Dominik Liebler
2016-09-23 11:29:28 +02:00
parent 8aa780fa4d
commit 79f25f8442
6 changed files with 53 additions and 46 deletions

View File

@@ -1,38 +0,0 @@
<?php
namespace DesignPatterns\Creational\Builder;
use DesignPatterns\Creational\Builder\Parts\Vehicle;
class BikeBuilder implements BuilderInterface
{
/**
* @var Parts\Bike
*/
private $bike;
public function addDoors()
{
}
public function addEngine()
{
$this->bike->setPart('engine', new Parts\Engine());
}
public function addWheel()
{
$this->bike->setPart('forwardWheel', new Parts\Wheel());
$this->bike->setPart('rearWheel', new Parts\Wheel());
}
public function createVehicle()
{
$this->bike = new Parts\Bike();
}
public function getVehicle(): Vehicle
{
return $this->bike;
}
}

View File

@@ -15,6 +15,7 @@ class CarBuilder implements BuilderInterface
{ {
$this->car->setPart('rightDoor', new Parts\Door()); $this->car->setPart('rightDoor', new Parts\Door());
$this->car->setPart('leftDoor', new Parts\Door()); $this->car->setPart('leftDoor', new Parts\Door());
$this->car->setPart('trunkLid', new Parts\Door());
} }
public function addEngine() public function addEngine()

View File

@@ -2,6 +2,6 @@
namespace DesignPatterns\Creational\Builder\Parts; namespace DesignPatterns\Creational\Builder\Parts;
class Bike extends Vehicle class Truck extends Vehicle
{ {
} }

View File

@@ -44,9 +44,9 @@ BuilderInterface.php
:language: php :language: php
:linenos: :linenos:
BikeBuilder.php TruckBuilder.php
.. literalinclude:: BikeBuilder.php .. literalinclude:: TruckBuilder.php
:language: php :language: php
:linenos: :linenos:
@@ -62,9 +62,9 @@ Parts/Vehicle.php
:language: php :language: php
:linenos: :linenos:
Parts/Bike.php Parts/Truck.php
.. literalinclude:: Parts/Bike.php .. literalinclude:: Parts/Truck.php
:language: php :language: php
:linenos: :linenos:

View File

@@ -2,7 +2,7 @@
namespace DesignPatterns\Creational\Builder\Tests; namespace DesignPatterns\Creational\Builder\Tests;
use DesignPatterns\Creational\Builder\BikeBuilder; use DesignPatterns\Creational\Builder\TruckBuilder;
use DesignPatterns\Creational\Builder\CarBuilder; use DesignPatterns\Creational\Builder\CarBuilder;
use DesignPatterns\Creational\Builder\Director; use DesignPatterns\Creational\Builder\Director;
@@ -10,10 +10,10 @@ class DirectorTest extends \PHPUnit_Framework_TestCase
{ {
public function testCanBuildBike() public function testCanBuildBike()
{ {
$bikeBuilder = new BikeBuilder(); $bikeBuilder = new TruckBuilder();
$newVehicle = (new Director())->build($bikeBuilder); $newVehicle = (new Director())->build($bikeBuilder);
$this->assertInstanceOf('DesignPatterns\Creational\Builder\Parts\Bike', $newVehicle); $this->assertInstanceOf('DesignPatterns\Creational\Builder\Parts\Truck', $newVehicle);
} }
public function testCanBuildCar() public function testCanBuildCar()

View File

@@ -0,0 +1,44 @@
<?php
namespace DesignPatterns\Creational\Builder;
use DesignPatterns\Creational\Builder\Parts\Vehicle;
class TruckBuilder implements BuilderInterface
{
/**
* @var Parts\Truck
*/
private $truck;
public function addDoors()
{
$this->truck->setPart('rightDoor', new Parts\Door());
$this->truck->setPart('leftDoor', new Parts\Door());
}
public function addEngine()
{
$this->truck->setPart('truckEngine', new Parts\Engine());
}
public function addWheel()
{
$this->truck->setPart('wheel1', new Parts\Wheel());
$this->truck->setPart('wheel2', new Parts\Wheel());
$this->truck->setPart('wheel3', new Parts\Wheel());
$this->truck->setPart('wheel4', new Parts\Wheel());
$this->truck->setPart('wheel5', new Parts\Wheel());
$this->truck->setPart('wheel6', new Parts\Wheel());
}
public function createVehicle()
{
$this->truck = new Parts\Truck();
}
public function getVehicle(): Vehicle
{
return $this->truck;
}
}