info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-08-03 13:37:27 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #476 from sjokkateer/improvement/EAV

Browse Source 
EAV: Update missing type declarations
This commit is contained in:
Dominik Liebler
2022-05-19 12:42:01 +02:00
committed by GitHub
parent 24078ed9de 83df396fc9
commit 7b24e1185a
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
More/EAV/Attribute.php
View File

@@ -15,7 +15,7 @@ class Attribute implements \Stringable
$this->values = new SplObjectStorage(); $this->values = new SplObjectStorage();
} }
public function addValue(Value $value) public function addValue(Value $value): void
{ {
$this->values->attach($value); $this->values->attach($value);
} }

2
More/EAV/Entity.php
View File

@@ -16,7 +16,7 @@ class Entity implements \Stringable
/** /**
* @param Value[] $values * @param Value[] $values
*/ */
public function __construct(private string $name, $values) public function __construct(private string $name, array $values)
{ {
$this->values = new SplObjectStorage(); $this->values = new SplObjectStorage();

2
More/EAV/Tests/EAVTest.php
View File

@@ -11,7 +11,7 @@ use PHPUnit\Framework\TestCase;
class EAVTest extends TestCase class EAVTest extends TestCase
{ {
public function testCanAddAttributeToEntity() public function testCanAddAttributeToEntity(): void
{ {
$colorAttribute = new Attribute('color'); $colorAttribute = new Attribute('color');
$colorSilver = new Value($colorAttribute, 'silver'); $colorSilver = new Value($colorAttribute, 'silver');