From 7bf6593e3f827e102fd683cb86f46da457ec4576 Mon Sep 17 00:00:00 2001 From: Antonio Spinelli Date: Tue, 15 Apr 2014 22:59:59 -0300 Subject: [PATCH] it was created the Creational namespace and append its patterns --- Creational/AbstractFactory/AbstractFactory.php | 2 +- .../{Test => }/AbstractFactoryTest.php | 10 +++++----- Creational/AbstractFactory/Html/Picture.php | 4 ++-- Creational/AbstractFactory/Html/Text.php | 4 ++-- Creational/AbstractFactory/HtmlFactory.php | 2 +- Creational/AbstractFactory/Json/Picture.php | 4 ++-- Creational/AbstractFactory/Json/Text.php | 4 ++-- Creational/AbstractFactory/JsonFactory.php | 2 +- Creational/AbstractFactory/MediaInterface.php | 2 +- Creational/AbstractFactory/Picture.php | 2 +- Creational/AbstractFactory/Text.php | 2 +- Creational/Builder/BikeBuilder.php | 2 +- Creational/Builder/BuilderInterface.php | 2 +- Creational/Builder/CarBuilder.php | 2 +- Creational/Builder/Director.php | 2 +- Creational/Builder/{Test => }/DirectorTest.php | 12 ++++++------ Creational/Builder/Parts/Bike.php | 2 +- Creational/Builder/Parts/Car.php | 2 +- Creational/Builder/Parts/Door.php | 2 +- Creational/Builder/Parts/Engine.php | 2 +- Creational/Builder/Parts/Vehicle.php | 2 +- Creational/Builder/Parts/Wheel.php | 2 +- Creational/FactoryMethod/Bicycle.php | 2 +- Creational/FactoryMethod/FactoryMethod.php | 2 +- .../{Test => }/FactoryMethodTest.php | 10 +++++----- Creational/FactoryMethod/Ferrari.php | 2 +- Creational/FactoryMethod/GermanFactory.php | 2 +- Creational/FactoryMethod/ItalianFactory.php | 2 +- Creational/FactoryMethod/Porsche.php | 2 +- Creational/FactoryMethod/VehicleInterface.php | 2 +- Creational/Multiton/Multiton.php | 2 +- {Pool => Creational/Pool}/Pool.php | 2 +- {Tests => Creational}/Pool/PoolTest.php | 8 +++----- {Pool => Creational/Pool}/Processor.php | 2 +- {Pool => Creational/Pool}/README.md | 0 {Pool => Creational/Pool}/Worker.php | 2 +- Creational/Prototype/BarBookPrototype.php | 2 +- Creational/Prototype/BookPrototype.php | 2 +- Creational/Prototype/FooBookPrototype.php | 2 +- Creational/Prototype/index.php | 2 +- Creational/SimpleFactory/Bicycle.php | 2 +- Creational/SimpleFactory/ConcreteFactory.php | 2 +- Creational/SimpleFactory/Scooter.php | 2 +- .../{Test => }/SimpleFactoryTest.php | 6 +++--- Creational/SimpleFactory/VehicleInterface.php | 2 +- Creational/Singleton/Singleton.php | 4 ++-- .../Singleton/{Test => }/SingletonTest.php | 6 +++--- Creational/StaticFactory/FormatNumber.php | 2 +- Creational/StaticFactory/FormatString.php | 2 +- Creational/StaticFactory/FormatterInterface.php | 2 +- Creational/StaticFactory/StaticFactory.php | 2 +- .../{Test => }/StaticFactoryTest.php | 6 +++--- Pool/index.php | 16 ---------------- 53 files changed, 77 insertions(+), 95 deletions(-) rename Creational/AbstractFactory/{Test => }/AbstractFactoryTest.php (74%) rename Creational/Builder/{Test => }/DirectorTest.php (66%) rename Creational/FactoryMethod/{Test => }/FactoryMethodTest.php (75%) rename {Pool => Creational/Pool}/Pool.php (91%) rename {Tests => Creational}/Pool/PoolTest.php (71%) rename {Pool => Creational/Pool}/Processor.php (96%) rename {Pool => Creational/Pool}/README.md (100%) rename {Pool => Creational/Pool}/Worker.php (89%) rename Creational/SimpleFactory/{Test => }/SimpleFactoryTest.php (76%) rename Creational/Singleton/{Test => }/SingletonTest.php (74%) rename Creational/StaticFactory/{Test => }/StaticFactoryTest.php (65%) delete mode 100644 Pool/index.php diff --git a/Creational/AbstractFactory/AbstractFactory.php b/Creational/AbstractFactory/AbstractFactory.php index 481e14e..84b4203 100644 --- a/Creational/AbstractFactory/AbstractFactory.php +++ b/Creational/AbstractFactory/AbstractFactory.php @@ -1,6 +1,6 @@ createText('footnotes') ); - $this->assertContainsOnly('DesignPatterns\AbstractFactory\MediaInterface', $article); + $this->assertContainsOnly('DesignPatterns\Creational\AbstractFactory\MediaInterface', $article); /* this is the time to look at the Builder pattern. This pattern * helps you to create complex object like that article above with diff --git a/Creational/AbstractFactory/Html/Picture.php b/Creational/AbstractFactory/Html/Picture.php index 2e648b0..3f224fc 100644 --- a/Creational/AbstractFactory/Html/Picture.php +++ b/Creational/AbstractFactory/Html/Picture.php @@ -1,8 +1,8 @@ director->build($builder); - $this->assertInstanceOf('DesignPatterns\Builder\Parts\Vehicle', $newVehicle); + $this->assertInstanceOf('DesignPatterns\Creational\Builder\Parts\Vehicle', $newVehicle); } } diff --git a/Creational/Builder/Parts/Bike.php b/Creational/Builder/Parts/Bike.php index 6ffa4e2..307b3e0 100644 --- a/Creational/Builder/Parts/Bike.php +++ b/Creational/Builder/Parts/Bike.php @@ -1,6 +1,6 @@ type as $oneType) { $vehicle = $shop->create($oneType); - $this->assertInstanceOf('DesignPatterns\FactoryMethod\VehicleInterface', $vehicle); + $this->assertInstanceOf('DesignPatterns\Creational\FactoryMethod\VehicleInterface', $vehicle); } } diff --git a/Creational/FactoryMethod/Ferrari.php b/Creational/FactoryMethod/Ferrari.php index f221e42..c905f91 100644 --- a/Creational/FactoryMethod/Ferrari.php +++ b/Creational/FactoryMethod/Ferrari.php @@ -1,6 +1,6 @@ get(); $this->assertEquals(1, $worker->id); @@ -27,6 +26,5 @@ class PoolTest extends \PHPUnit_Framework_TestCase $this->assertEquals(5, $pool->get()->id); $this->assertEquals(1, $pool->get()->id); } - } diff --git a/Pool/Processor.php b/Creational/Pool/Processor.php similarity index 96% rename from Pool/Processor.php rename to Creational/Pool/Processor.php index eabd51d..47523b0 100644 --- a/Pool/Processor.php +++ b/Creational/Pool/Processor.php @@ -1,6 +1,6 @@ factory->createVehicle($type); - $this->assertInstanceOf('DesignPatterns\SimpleFactory\VehicleInterface', $obj); + $this->assertInstanceOf('DesignPatterns\Creational\SimpleFactory\VehicleInterface', $obj); } /** diff --git a/Creational/SimpleFactory/VehicleInterface.php b/Creational/SimpleFactory/VehicleInterface.php index 66dc3fd..eb13a66 100644 --- a/Creational/SimpleFactory/VehicleInterface.php +++ b/Creational/SimpleFactory/VehicleInterface.php @@ -1,6 +1,6 @@ assertInstanceOf('DesignPatterns\Singleton\Singleton', $firstCall); + $this->assertInstanceOf('DesignPatterns\Creational\Singleton\Singleton', $firstCall); $secondCall = Singleton::getInstance(); $this->assertSame($firstCall, $secondCall); } diff --git a/Creational/StaticFactory/FormatNumber.php b/Creational/StaticFactory/FormatNumber.php index 8b20db2..93ac7c7 100644 --- a/Creational/StaticFactory/FormatNumber.php +++ b/Creational/StaticFactory/FormatNumber.php @@ -1,6 +1,6 @@ global => evil diff --git a/Creational/StaticFactory/Test/StaticFactoryTest.php b/Creational/StaticFactory/StaticFactoryTest.php similarity index 65% rename from Creational/StaticFactory/Test/StaticFactoryTest.php rename to Creational/StaticFactory/StaticFactoryTest.php index d85f266..1582e56 100644 --- a/Creational/StaticFactory/Test/StaticFactoryTest.php +++ b/Creational/StaticFactory/StaticFactoryTest.php @@ -1,8 +1,8 @@ assertInstanceOf('DesignPatterns\StaticFactory\FormatterInterface', $obj); + $this->assertInstanceOf('DesignPatterns\Creational\StaticFactory\FormatterInterface', $obj); } } diff --git a/Pool/index.php b/Pool/index.php deleted file mode 100644 index 3059efe..0000000 --- a/Pool/index.php +++ /dev/null @@ -1,16 +0,0 @@ -process('image1.jpg'); -$processor->process('image2.jpg'); -$processor->process('image3.jpg'); -$processor->process('image4.jpg'); -$processor->process('image5.jpg'); -$processor->process('image6.jpg'); -$processor->process('image7.jpg'); -$processor->process('image8.jpg');