From 94edeede4ecc56cd0fc12ba06fc24673e3e03b09 Mon Sep 17 00:00:00 2001
From: Trismegiste <florent.g@allopneus.com>
Date: Sat, 11 May 2013 12:01:06 +0200
Subject: [PATCH 1/2] Comments to explain how this example misses the point of
 the pattern

---
 Iterator/Iterator.php | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Iterator/Iterator.php b/Iterator/Iterator.php
index d27adae..753ce77 100644
--- a/Iterator/Iterator.php
+++ b/Iterator/Iterator.php
@@ -32,6 +32,8 @@ class File
 
     public function process()
     {
+        // this is the place to show how using an iterator, with foreach
+        // See the CardGame.php file
         $this->_rowset->process();
     }
 }
@@ -55,6 +57,14 @@ class Rowset implements Iterator
     public function process()
     {
         // this actually calls rewind(), { next(), valid(), key() and current() :}
+        /**
+         * THE key feature of the Iterator Pattern is to provide a *public contract*
+         * to iterate on a collection without knowing how items are handled inside
+         * the collection. It is not just an easy way to use "foreach"
+         * 
+         * One cannot see the point of iterator pattern if you iterate on $this.
+         * This example is unclear and mixed with some Composite pattern ideas. 
+         */
         foreach ($this as $line => $row) {
             $row->process();
         }

From aa8069fc4585d0f5bed851e7eaa82bd27620425c Mon Sep 17 00:00:00 2001
From: Trismegiste <florent.g@allopneus.com>
Date: Sat, 11 May 2013 12:47:26 +0200
Subject: [PATCH 2/2] a relevant example for iterator

---
 Iterator/CardGame.php           | 80 +++++++++++++++++++++++++++++++++
 Tests/Iterator/IteratorTest.php | 56 +++++++++++++++++++++++
 2 files changed, 136 insertions(+)
 create mode 100644 Iterator/CardGame.php
 create mode 100644 Tests/Iterator/IteratorTest.php

diff --git a/Iterator/CardGame.php b/Iterator/CardGame.php
new file mode 100644
index 0000000..c4b3898
--- /dev/null
+++ b/Iterator/CardGame.php
@@ -0,0 +1,80 @@
+<?php
+
+/*
+ * DesignPatternPHP
+ */
+
+namespace DesignPatterns\Iterator;
+
+/**
+ * Iterator provides a standard way to iterate over a collection without knowing
+ * how it is implemented. All you need to know is : you can traverse it
+ * with current, valid, next, rewind and key.
+ * 
+ * That's the key feature of this pattern :
+ * The underlaying machinery could be an array, a matrix, a file, a cursor
+ * from database, a webservice with a cache, you don't care anymore.
+ * 
+ * Note: This design pattern changes from one language to another. It depends 
+ * mostly how loop statements handle collections (see Java before and after 1.5)
+ * 
+ * In this simple example, I try to demonstrate how I manage a "linear" iterator
+ * on a card game but in fact, the underlaying storage is handled by two combined
+ * arrays.
+ * 
+ * If tomorrow you decide to read cards from a database, the client 
+ * (see the PHPUnit test) will remain unchanged. That's beauty of it.
+ */
+class CardGame implements \Iterator
+{
+
+    protected $color = array('D', 'S', 'C', 'H');
+    protected $number = array(7, 8, 9, 10, 'J', 'Q', 'K', 'A');
+
+    /**
+     * Return the current value
+     */
+    public function current()
+    {
+        return current($this->number) . ' of ' . current($this->color);
+    }
+
+    /**
+     * Return the current key
+     */
+    public function key()
+    {
+        return current($this->color) . current($this->number);
+    }
+
+    /**
+     * Go to the next item in the collection
+     */
+    public function next()
+    {
+        if (false === next($this->number)) {
+            if (false !== next($this->color)) {
+                reset($this->number);
+            }
+        }
+    }
+
+    /**
+     * Go to the first item in the collection
+     */
+    public function rewind()
+    {
+        reset($this->color);
+        reset($this->number);
+    }
+
+    /**
+     * Is the current position a valid item (true) 
+     * or do we reach the end (false) ?
+     */
+    public function valid()
+    {
+        return current($this->number) || current($this->color);
+    }
+
+}
\ No newline at end of file
diff --git a/Tests/Iterator/IteratorTest.php b/Tests/Iterator/IteratorTest.php
new file mode 100644
index 0000000..6b9fd12
--- /dev/null
+++ b/Tests/Iterator/IteratorTest.php
@@ -0,0 +1,56 @@
+<?php
+
+/*
+ * DesignPatternPHP
+ */
+
+namespace DesignPatterns\Tests\Iterator;
+
+use DesignPatterns\Iterator\CardGame;
+
+/**
+ * IteratorTest the CardGame iterator
+ *
+ * @author flo
+ */
+class IteratorTest extends \PHPUnit_Framework_TestCase
+{
+
+    protected $game;
+
+    protected function setUp()
+    {
+        $this->game = new CardGame();
+    }
+
+    /**
+     * This is the client of the iterator.
+     * It remains unchanged even if one I decide to use MongoDB to store the
+     * card.
+     */
+    public function testCardinal()
+    {
+        $counter = 0;
+        foreach ($this->game as $key => $card) {
+            $counter++;
+        }
+
+        $this->assertEquals(32, $counter);
+    }
+
+    /**
+     * Some fancy functions of PHP.
+     */
+    public function testExampleOf_PHP_Helper()
+    {
+        // PHPUnit works on array or iterator :
+        $this->assertCount(32, $this->game);
+        // a easy way to get an array from interator :
+        $cards = iterator_to_array($this->game);
+        $this->assertEquals('A of S', $cards['SA']);
+        // a easy way to get an iterator from an array :
+        $iterator = new \ArrayIterator($cards);
+        $this->assertInstanceOf('\Iterator', $iterator);
+    }
+
+}
\ No newline at end of file