PHP7 Builder

Creational/Builder/BikeBuilder.php

@@ -2,52 +2,36 @@
 
 namespace DesignPatterns\Creational\Builder;
 
-/**
+use DesignPatterns\Creational\Builder\Parts\Vehicle;
- * BikeBuilder builds bike.
+
- */
 class BikeBuilder implements BuilderInterface
 {
     /**
      * @var Parts\Bike
      */
-    protected $bike;
+    private $bike;
 
-    /**
-     * {@inheritdoc}
-     */
     public function addDoors()
     {
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function addEngine()
     {
         $this->bike->setPart('engine', new Parts\Engine());
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function addWheel()
     {
         $this->bike->setPart('forwardWheel', new Parts\Wheel());
         $this->bike->setPart('rearWheel', new Parts\Wheel());
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function createVehicle()
     {
         $this->bike = new Parts\Bike();
     }
 
-    /**
+    public function getVehicle(): Vehicle
-     * {@inheritdoc}
-     */
-    public function getVehicle()
     {
         return $this->bike;
     }

Creational/Builder/BuilderInterface.php

@@ -2,30 +2,17 @@
 
 namespace DesignPatterns\Creational\Builder;
 
+use DesignPatterns\Creational\Builder\Parts\Vehicle;
+
 interface BuilderInterface
 {
-    /**
-     * @return mixed
-     */
     public function createVehicle();
 
-    /**
-     * @return mixed
-     */
     public function addWheel();
 
-    /**
-     * @return mixed
-     */
     public function addEngine();
 
-    /**
-     * @return mixed
-     */
     public function addDoors();
 
-    /**
+    public function getVehicle(): Vehicle;
-     * @return mixed
-     */
-    public function getVehicle();
 }

Creational/Builder/CarBuilder.php

@@ -2,36 +2,26 @@
 
 namespace DesignPatterns\Creational\Builder;
 
-/**
+use DesignPatterns\Creational\Builder\Parts\Vehicle;
- * CarBuilder builds car.
+
- */
 class CarBuilder implements BuilderInterface
 {
     /**
      * @var Parts\Car
      */
-    protected $car;
+    private $car;
 
-    /**
-     * @return void
-     */
     public function addDoors()
     {
-        $this->car->setPart('rightdoor', new Parts\Door());
+        $this->car->setPart('rightDoor', new Parts\Door());
         $this->car->setPart('leftDoor', new Parts\Door());
     }
 
-    /**
-     * @return void
-     */
     public function addEngine()
     {
         $this->car->setPart('engine', new Parts\Engine());
     }
 
-    /**
-     * @return void
-     */
     public function addWheel()
     {
         $this->car->setPart('wheelLF', new Parts\Wheel());
@@ -40,18 +30,12 @@ class CarBuilder implements BuilderInterface
         $this->car->setPart('wheelRR', new Parts\Wheel());
     }
 
-    /**
-     * @return void
-     */
     public function createVehicle()
     {
         $this->car = new Parts\Car();
     }
 
-    /**
+    public function getVehicle(): Vehicle
-     * @return Parts\Car
-     */
-    public function getVehicle()
     {
         return $this->car;
     }

Creational/Builder/Director.php

@@ -2,22 +2,17 @@
 
 namespace DesignPatterns\Creational\Builder;
 
+use DesignPatterns\Creational\Builder\Parts\Vehicle;
+
 /**
  * Director is part of the builder pattern. It knows the interface of the builder
- * and builds a complex object with the help of the builder.
+ * and builds a complex object with the help of the builder
  *
  * You can also inject many builders instead of one to build more complex objects
  */
 class Director
 {
-    /**
+    public function build(BuilderInterface $builder): Vehicle
-     * The director don't know about concrete part.
-     *
-     * @param BuilderInterface $builder
-     *
-     * @return Parts\Vehicle
-     */
-    public function build(BuilderInterface $builder)
     {
         $builder->createVehicle();
         $builder->addDoors();

Creational/Builder/Parts/Bike.php

@@ -2,9 +2,6 @@
 
 namespace DesignPatterns\Creational\Builder\Parts;
 
-/**
- * Bike is a bike.
- */
 class Bike extends Vehicle
 {
 }

Creational/Builder/Parts/Car.php

@@ -2,9 +2,6 @@
 
 namespace DesignPatterns\Creational\Builder\Parts;
 
-/**
- * Car is a car.
- */
 class Car extends Vehicle
 {
 }

Creational/Builder/Parts/Vehicle.php

@@ -2,19 +2,16 @@
 
 namespace DesignPatterns\Creational\Builder\Parts;
 
-/**
- * Vehicle class is an abstraction for a vehicle.
- */
 abstract class Vehicle
 {
     /**
-     * @var array
+     * @var object[]
      */
-    protected $data;
+    private $data = [];
 
     /**
      * @param string $key
-     * @param mixed  $value
+     * @param object $value
      */
     public function setPart($key, $value)
     {

Creational/Builder/Tests/DirectorTest.php

@@ -3,39 +3,24 @@
 namespace DesignPatterns\Creational\Builder\Tests;
 
 use DesignPatterns\Creational\Builder\BikeBuilder;
-use DesignPatterns\Creational\Builder\BuilderInterface;
 use DesignPatterns\Creational\Builder\CarBuilder;
 use DesignPatterns\Creational\Builder\Director;
 
-/**
- * DirectorTest tests the builder pattern.
- */
 class DirectorTest extends \PHPUnit_Framework_TestCase
 {
-    protected $director;
+    public function testCanBuildBike()
-
-    protected function setUp()
     {
-        $this->director = new Director();
+        $bikeBuilder = new BikeBuilder();
+        $newVehicle = (new Director())->build($bikeBuilder);
+
+        $this->assertInstanceOf('DesignPatterns\Creational\Builder\Parts\Bike', $newVehicle);
     }
 
-    public function getBuilder()
+    public function testCanBuildCar()
     {
-        return array(
+        $carBuilder = new CarBuilder();
-            array(new CarBuilder()),
+        $newVehicle = (new Director())->build($carBuilder);
-            array(new BikeBuilder()),
-        );
-    }
 
-    /**
+        $this->assertInstanceOf('DesignPatterns\Creational\Builder\Parts\Car', $newVehicle);
-     * Here we test the build process. Notice that the client don't know
-     * anything about the concrete builder.
-     *
-     * @dataProvider getBuilder
-     */
-    public function testBuild(BuilderInterface $builder)
-    {
-        $newVehicle = $this->director->build($builder);
-        $this->assertInstanceOf('DesignPatterns\Creational\Builder\Parts\Vehicle', $newVehicle);
     }
 }