info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-08-03 13:37:27 +02:00
Code Issues Projects Releases Wiki Activity

WorkerPool :: added missing return type & strict comparison

Browse Source
This commit is contained in:
Atakan Demircioğlu
2022-06-30 00:54:32 +03:00
parent 33fe6d7ee6
commit b2d6414f81
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Creational/Pool/WorkerPool.php
View File

@@ -20,7 +20,7 @@ class WorkerPool implements Countable
public function get(): StringReverseWorker public function get(): StringReverseWorker
{ {
if (count($this->freeWorkers) == 0) { if (count($this->freeWorkers) === 0) {
$worker = new StringReverseWorker(); $worker = new StringReverseWorker();
} else { } else {
$worker = array_pop($this->freeWorkers); $worker = array_pop($this->freeWorkers);
@@ -31,10 +31,9 @@ class WorkerPool implements Countable
return $worker; return $worker;
} }
public function dispose(StringReverseWorker $worker) public function dispose(StringReverseWorker $worker): void
{ {
$key = spl_object_hash($worker); $key = spl_object_hash($worker);
if (isset($this->occupiedWorkers[$key])) { if (isset($this->occupiedWorkers[$key])) {
unset($this->occupiedWorkers[$key]); unset($this->occupiedWorkers[$key]);
$this->freeWorkers[$key] = $worker; $this->freeWorkers[$key] = $worker;