info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-08-04 22:17:25 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #280 from vuurball/master

Browse Source 
Specification pattern - performance optimization
This commit is contained in:
Dominik Liebler
2017-04-13 07:46:35 +02:00
committed by GitHub
parent c3116c9e91 eb847fbfb2
commit bdf8c494f0
2 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Behavioral/Specification/AndSpecification.php
View File

@@ -17,14 +17,17 @@ class AndSpecification implements SpecificationInterface
$this->specifications = $specifications; $this->specifications = $specifications;
} }
/**
* if at least one specification is false, return false, else return true.
*/
public function isSatisfiedBy(Item $item): bool public function isSatisfiedBy(Item $item): bool
{ {
$satisfied = [];
foreach ($this->specifications as $specification) { foreach ($this->specifications as $specification) {
$satisfied[] = $specification->isSatisfiedBy($item); if (!$specification->isSatisfiedBy($item)) {
return false;
}
} }
return !in_array(false, $satisfied); return true;
} }
} }

12
Behavioral/Specification/OrSpecification.php
View File

@@ -17,14 +17,16 @@ class OrSpecification implements SpecificationInterface
$this->specifications = $specifications; $this->specifications = $specifications;
} }
/**
* if at least one specification is true, return true, else return false
*/
public function isSatisfiedBy(Item $item): bool public function isSatisfiedBy(Item $item): bool
{ {
$satisfied = [];
foreach ($this->specifications as $specification) { foreach ($this->specifications as $specification) {
$satisfied[] = $specification->isSatisfiedBy($item); if ($specification->isSatisfiedBy($item)) {
return true;
}
} }
return false;
return in_array(true, $satisfied);
} }
} }