info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-08-02 13:07:27 +02:00
Code Issues Projects Releases Wiki Activity

Replace array storage with SplObjectStorage

Browse Source 
If you already use SPL interfaces in your example, maybe better to use `SplObjectStorage` too instead of `array` to store observers with `attach` and `detach` convenient methods?
What do you think?
This commit is contained in:
Bocharsky Victor
2015-05-27 21:37:19 +03:00
parent 23d8483738
commit db7dab5b0d
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
Behavioral/Observer/User.php
View File

@@ -20,9 +20,14 @@ class User implements \SplSubject
/** /**
* observers * observers
* *
* @var array * @var \SplObjectStorage
*/ */
protected $observers = array(); protected $observers;
function __construct()
{
$this->observers = new \SplObjectStorage();
}
/** /**
* attach a new observer * attach a new observer
@@ -33,7 +38,7 @@ class User implements \SplSubject
*/ */
public function attach(\SplObserver $observer) public function attach(\SplObserver $observer)
{ {
$this->observers[] = $observer; $this->observers->attach($observer);
} }
/** /**
@@ -45,11 +50,7 @@ class User implements \SplSubject
*/ */
public function detach(\SplObserver $observer) public function detach(\SplObserver $observer)
{ {
$index = array_search($observer, $this->observers); $this->observers->detach($observer);
if (false !== $index) {
unset($this->observers[$index]);
}
} }
/** /**