mirror of
https://github.com/DesignPatternsPHP/DesignPatternsPHP.git
synced 2025-07-20 06:41:15 +02:00
cs fix
This commit is contained in:
Behavioral
ChainOfResponsibilities
Iterator
Observer
Specification
Strategy
TemplateMethod
Visitor
Creational
Structural
Adapter
Composite
DataMapper
Decorator
DependencyInjection
@@ -45,7 +45,8 @@ class ChainTest extends \PHPUnit_Framework_TestCase
|
||||
$this->assertObjectHasAttribute('response', $request);
|
||||
$this->assertEquals('baz', $request->response);
|
||||
// despite both handle owns the 'bar' key, the FastStorage is responding first
|
||||
$this->assertEquals('DesignPatterns\Behavioral\ChainOfResponsibilities\Responsible\FastStorage', $request->forDebugOnly);
|
||||
$className = 'DesignPatterns\Behavioral\ChainOfResponsibilities\Responsible\FastStorage';
|
||||
$this->assertEquals($className, $request->forDebugOnly);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -60,7 +61,8 @@ class ChainTest extends \PHPUnit_Framework_TestCase
|
||||
$this->assertObjectHasAttribute('response', $request);
|
||||
$this->assertEquals('bar', $request->response);
|
||||
// FastStorage has no 'foo' key, the SlowStorage is responding
|
||||
$this->assertEquals('DesignPatterns\Behavioral\ChainOfResponsibilities\Responsible\SlowStorage', $request->forDebugOnly);
|
||||
$className = 'DesignPatterns\Behavioral\ChainOfResponsibilities\Responsible\SlowStorage';
|
||||
$this->assertEquals($className, $request->forDebugOnly);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -73,6 +75,7 @@ class ChainTest extends \PHPUnit_Framework_TestCase
|
||||
|
||||
$this->assertFalse($ret);
|
||||
// the last responsible :
|
||||
$this->assertEquals('DesignPatterns\Behavioral\ChainOfResponsibilities\Responsible\SlowStorage', $request->forDebugOnly);
|
||||
$className = 'DesignPatterns\Behavioral\ChainOfResponsibilities\Responsible\SlowStorage';
|
||||
$this->assertEquals($className, $request->forDebugOnly);
|
||||
}
|
||||
}
|
||||
|
@@ -13,7 +13,7 @@ class BookList implements \Countable
|
||||
return $this->books[$bookNumberToGet];
|
||||
}
|
||||
|
||||
return NULL;
|
||||
return null;
|
||||
}
|
||||
|
||||
public function addBook(Book $book)
|
||||
|
@@ -53,10 +53,9 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
|
||||
$subject->attach($observer);
|
||||
|
||||
$observer->expects($this->once())
|
||||
->method('update')
|
||||
->with($subject);
|
||||
->method('update')
|
||||
->with($subject);
|
||||
|
||||
$subject->notify();
|
||||
}
|
||||
|
||||
}
|
@@ -15,7 +15,6 @@ class Plus extends AbstractSpecification
|
||||
*
|
||||
* @param SpecificationInterface $left
|
||||
* @param SpecificationInterface $right
|
||||
|
||||
*/
|
||||
public function __construct(SpecificationInterface $left, SpecificationInterface $right)
|
||||
{
|
||||
|
@@ -38,10 +38,10 @@ class PriceSpecification extends AbstractSpecification
|
||||
*/
|
||||
public function isSatisfiedBy(Item $item)
|
||||
{
|
||||
if ( !empty($this->maxPrice) && $item->getPrice() > $this->maxPrice) {
|
||||
if (!empty($this->maxPrice) && $item->getPrice() > $this->maxPrice) {
|
||||
return false;
|
||||
}
|
||||
if ( !empty($this->minPrice) && $item->getPrice() < $this->minPrice) {
|
||||
if (!empty($this->minPrice) && $item->getPrice() < $this->minPrice) {
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@@ -19,7 +19,6 @@ interface SpecificationInterface
|
||||
* Creates a logical AND specification
|
||||
*
|
||||
* @param SpecificationInterface $spec
|
||||
|
||||
*/
|
||||
public function plus(SpecificationInterface $spec);
|
||||
|
||||
@@ -27,7 +26,6 @@ interface SpecificationInterface
|
||||
* Creates a logical OR specification
|
||||
*
|
||||
* @param SpecificationInterface $spec
|
||||
|
||||
*/
|
||||
public function either(SpecificationInterface $spec);
|
||||
|
||||
|
@@ -30,7 +30,7 @@ class ObjectCollection
|
||||
*/
|
||||
public function sort()
|
||||
{
|
||||
if (!$this->comparator){
|
||||
if (!$this->comparator) {
|
||||
throw new \LogicException("Comparator is not set");
|
||||
}
|
||||
|
||||
|
@@ -31,8 +31,8 @@ class JourneyTest extends \PHPUnit_Framework_TestCase
|
||||
{
|
||||
$journey = $this->getMockForAbstractClass('DesignPatterns\Behavioral\TemplateMethod\Journey');
|
||||
$journey->expects($this->once())
|
||||
->method('enjoyVacation')
|
||||
->will($this->returnCallback(array($this, 'mockUpVacation')));
|
||||
->method('enjoyVacation')
|
||||
->will($this->returnCallback(array($this, 'mockUpVacation')));
|
||||
$this->expectOutputRegex('#Las Vegas#');
|
||||
$journey->takeATrip();
|
||||
}
|
||||
@@ -41,5 +41,4 @@ class JourneyTest extends \PHPUnit_Framework_TestCase
|
||||
{
|
||||
echo "Fear and loathing in Las Vegas\n";
|
||||
}
|
||||
|
||||
}
|
@@ -43,5 +43,4 @@ class VisitorTest extends \PHPUnit_Framework_TestCase
|
||||
$mock = $this->getMockForAbstractClass('DesignPatterns\Behavioral\Visitor\Role');
|
||||
$mock->accept($this->visitor);
|
||||
}
|
||||
|
||||
}
|
@@ -26,5 +26,4 @@ class Pool
|
||||
{
|
||||
$this->instances[] = $instance;
|
||||
}
|
||||
|
||||
}
|
||||
|
@@ -2,8 +2,6 @@
|
||||
|
||||
namespace DesignPatterns\Creational\Pool;
|
||||
|
||||
use DesignPatterns\Creational\Pool\Pool;
|
||||
|
||||
class TestWorker
|
||||
{
|
||||
|
||||
@@ -27,4 +25,3 @@ class PoolTest extends \PHPUnit_Framework_TestCase
|
||||
$this->assertEquals(1, $pool->get()->id);
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -49,5 +49,4 @@ class Processor
|
||||
{
|
||||
return array_pop($this->waitingQueue);
|
||||
}
|
||||
|
||||
}
|
||||
|
@@ -17,5 +17,4 @@ class Worker
|
||||
// and when it's done, execute callback
|
||||
call_user_func($callback, $this);
|
||||
}
|
||||
|
||||
}
|
||||
|
@@ -41,5 +41,4 @@ class SimpleFactoryTest extends \PHPUnit_Framework_TestCase
|
||||
{
|
||||
$this->factory->createVehicle('car');
|
||||
}
|
||||
|
||||
}
|
@@ -33,7 +33,7 @@ class AdapterTest extends \PHPUnit_Framework_TestCase
|
||||
*
|
||||
* @dataProvider getBook
|
||||
*/
|
||||
public function test_I_am_an_old_Client(PaperBookInterface $book)
|
||||
public function testIAmAnOldClient(PaperBookInterface $book)
|
||||
{
|
||||
$book->open();
|
||||
$book->turnPage();
|
||||
|
@@ -29,6 +29,8 @@ class CompositeTest extends \PHPUnit_Framework_TestCase
|
||||
*/
|
||||
public function testFormImplementsFormEelement()
|
||||
{
|
||||
$this->assertTrue(is_subclass_of('DesignPatterns\Structural\Composite\Form', 'DesignPatterns\Structural\Composite\FormElement'));
|
||||
$className = 'DesignPatterns\Structural\Composite\Form';
|
||||
$abstractName = 'DesignPatterns\Structural\Composite\FormElement';
|
||||
$this->assertTrue(is_subclass_of($className, $abstractName));
|
||||
}
|
||||
}
|
||||
|
@@ -65,7 +65,12 @@ class DataMapperTest extends \PHPUnit_Framework_TestCase
|
||||
*/
|
||||
public function testRestoreOne(User $existing)
|
||||
{
|
||||
$rows = new \ArrayIterator(array(array('userid' => 1, 'username' => 'Odysseus', 'email' => 'Odysseus@ithaca.gr')));
|
||||
$row = array(
|
||||
'userid' => 1,
|
||||
'username' => 'Odysseus',
|
||||
'email' => 'Odysseus@ithaca.gr'
|
||||
);
|
||||
$rows = new \ArrayIterator(array($row));
|
||||
$this->dbal->expects($this->once())
|
||||
->method('find')
|
||||
->with(1)
|
||||
|
@@ -30,7 +30,8 @@ class DecoratorTest extends \PHPUnit_Framework_TestCase
|
||||
// Wrap service with a JSON decorator for renderers
|
||||
$service = new Decorator\RenderInXml($this->service);
|
||||
// Our Renderer will now output XML instead of an array
|
||||
$this->assertXmlStringEqualsXmlString('<?xml version="1.0"?><foo>bar</foo>', $service->renderData());
|
||||
$xml = '<?xml version="1.0"?><foo>bar</foo>';
|
||||
$this->assertXmlStringEqualsXmlString($xml, $service->renderData());
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -38,7 +39,9 @@ class DecoratorTest extends \PHPUnit_Framework_TestCase
|
||||
*/
|
||||
public function testDecoratorMustImplementsRenderer()
|
||||
{
|
||||
$this->assertTrue(is_subclass_of('DesignPatterns\Structural\Decorator\Decorator', 'DesignPatterns\Structural\Decorator\RendererInterface'));
|
||||
$className = 'DesignPatterns\Structural\Decorator\Decorator';
|
||||
$interfaceName = 'DesignPatterns\Structural\Decorator\RendererInterface';
|
||||
$this->assertTrue(is_subclass_of($className, $interfaceName));
|
||||
}
|
||||
|
||||
/**
|
||||
|
@@ -13,10 +13,11 @@ class ArrayConfig extends AbstractConfig implements Parameters
|
||||
* Get parameter
|
||||
*
|
||||
* @param string|int $key
|
||||
*
|
||||
* @param null $default
|
||||
* @return mixed
|
||||
*/
|
||||
public function get($key, $default = null) {
|
||||
public function get($key, $default = null)
|
||||
{
|
||||
if (isset($this->storage[$key])) {
|
||||
return $this->storage[$key];
|
||||
}
|
||||
@@ -27,7 +28,7 @@ class ArrayConfig extends AbstractConfig implements Parameters
|
||||
* Set parameter
|
||||
*
|
||||
* @param string|int $key
|
||||
* @param mixed $value
|
||||
* @param mixed $value
|
||||
*/
|
||||
public function set($key, $value)
|
||||
{
|
||||
|
Reference in New Issue
Block a user