Applied fixes from StyleCI

This commit is contained in:
Dominik Liebler
2015-12-21 07:28:20 -05:00
committed by StyleCI Bot
parent 3663603b80
commit fe1f144ec3
167 changed files with 510 additions and 517 deletions

View File

@@ -2,15 +2,14 @@
namespace DesignPatterns\Behavioral\Observer\Tests;
use DesignPatterns\Behavioral\Observer\UserObserver;
use DesignPatterns\Behavioral\Observer\User;
use DesignPatterns\Behavioral\Observer\UserObserver;
/**
* ObserverTest tests the Observer pattern
* ObserverTest tests the Observer pattern.
*/
class ObserverTest extends \PHPUnit_Framework_TestCase
{
protected $observer;
protected function setUp()
@@ -19,7 +18,7 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
}
/**
* Tests the notification
* Tests the notification.
*/
public function testNotify()
{
@@ -31,7 +30,7 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
}
/**
* Tests the subscribing
* Tests the subscribing.
*/
public function testAttachDetach()
{
@@ -53,7 +52,7 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
}
/**
* Tests the update() invocation on a mockup
* Tests the update() invocation on a mockup.
*/
public function testUpdateCalling()
{

View File

@@ -3,34 +3,33 @@
namespace DesignPatterns\Behavioral\Observer;
/**
* Observer pattern : The observed object (the subject)
* Observer pattern : The observed object (the subject).
*
* The subject maintains a list of Observers and sends notifications.
*
*/
class User implements \SplSubject
{
/**
* user data
* user data.
*
* @var array
*/
protected $data = array();
/**
* observers
* observers.
*
* @var \SplObjectStorage
*/
protected $observers;
public function __construct()
{
$this->observers = new \SplObjectStorage();
}
/**
* attach a new observer
* attach a new observer.
*
* @param \SplObserver $observer
*
@@ -42,7 +41,7 @@ class User implements \SplSubject
}
/**
* detach an observer
* detach an observer.
*
* @param \SplObserver $observer
*
@@ -54,7 +53,7 @@ class User implements \SplSubject
}
/**
* notify observers
* notify observers.
*
* @return void
*/
@@ -68,7 +67,7 @@ class User implements \SplSubject
/**
* Ideally one would better write setter/getter for all valid attributes and only call notify()
* on attributes that matter when changed
* on attributes that matter when changed.
*
* @param string $name
* @param mixed $value

View File

@@ -3,18 +3,18 @@
namespace DesignPatterns\Behavioral\Observer;
/**
* class UserObserver
* class UserObserver.
*/
class UserObserver implements \SplObserver
{
/**
* This is the only method to implement as an observer.
* It is called by the Subject (usually by SplSubject::notify() )
* It is called by the Subject (usually by SplSubject::notify() ).
*
* @param \SplSubject $subject
*/
public function update(\SplSubject $subject)
{
echo get_class($subject) . ' has been updated';
echo get_class($subject).' has been updated';
}
}