mirror of
https://github.com/DesignPatternsPHP/DesignPatternsPHP.git
synced 2025-08-10 08:54:03 +02:00
Applied fixes from StyleCI
This commit is contained in:
committed by
StyleCI Bot
parent
3663603b80
commit
fe1f144ec3
@@ -3,7 +3,7 @@
|
||||
namespace DesignPatterns\Creational\StaticFactory;
|
||||
|
||||
/**
|
||||
* Class FormatNumber
|
||||
* Class FormatNumber.
|
||||
*/
|
||||
class FormatNumber implements FormatterInterface
|
||||
{
|
||||
|
@@ -3,7 +3,7 @@
|
||||
namespace DesignPatterns\Creational\StaticFactory;
|
||||
|
||||
/**
|
||||
* Class FormatString
|
||||
* Class FormatString.
|
||||
*/
|
||||
class FormatString implements FormatterInterface
|
||||
{
|
||||
|
@@ -3,7 +3,7 @@
|
||||
namespace DesignPatterns\Creational\StaticFactory;
|
||||
|
||||
/**
|
||||
* Class FormatterInterface
|
||||
* Class FormatterInterface.
|
||||
*/
|
||||
interface FormatterInterface
|
||||
{
|
||||
|
@@ -4,23 +4,24 @@ namespace DesignPatterns\Creational\StaticFactory;
|
||||
|
||||
/**
|
||||
* Note1: Remember, static => global => evil
|
||||
* Note2: Cannot be subclassed or mock-upped or have multiple different instances
|
||||
* Note2: Cannot be subclassed or mock-upped or have multiple different instances.
|
||||
*/
|
||||
class StaticFactory
|
||||
{
|
||||
/**
|
||||
* the parametrized function to get create an instance
|
||||
* the parametrized function to get create an instance.
|
||||
*
|
||||
* @param string $type
|
||||
*
|
||||
* @static
|
||||
*
|
||||
* @throws \InvalidArgumentException
|
||||
*
|
||||
* @return FormatterInterface
|
||||
*/
|
||||
public static function factory($type)
|
||||
{
|
||||
$className = __NAMESPACE__ . '\Format' . ucfirst($type);
|
||||
$className = __NAMESPACE__.'\Format'.ucfirst($type);
|
||||
|
||||
if (!class_exists($className)) {
|
||||
throw new \InvalidArgumentException('Missing format class.');
|
||||
|
@@ -5,17 +5,15 @@ namespace DesignPatterns\Creational\StaticFactory\Tests;
|
||||
use DesignPatterns\Creational\StaticFactory\StaticFactory;
|
||||
|
||||
/**
|
||||
* Tests for Static Factory pattern
|
||||
*
|
||||
* Tests for Static Factory pattern.
|
||||
*/
|
||||
class StaticFactoryTest extends \PHPUnit_Framework_TestCase
|
||||
{
|
||||
|
||||
public function getTypeList()
|
||||
{
|
||||
return array(
|
||||
array('string'),
|
||||
array('number')
|
||||
array('number'),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -33,6 +31,6 @@ class StaticFactoryTest extends \PHPUnit_Framework_TestCase
|
||||
*/
|
||||
public function testException()
|
||||
{
|
||||
StaticFactory::factory("");
|
||||
StaticFactory::factory('');
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user