info/clean-code-php
1
0
Fork 0
mirror of https://github.com/jupeter/clean-code-php.git synced 2025-09-26 05:59:04 +02:00
Code Issues Releases Wiki Activity

use PSR CS

Browse Source
This commit is contained in:
Peter Gribanov
2017-09-05 18:40:18 +03:00
committed by GitHub
parent 35e673e0ca
commit 068bf035f9
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
README.md
View File

@@ -495,6 +495,7 @@ function createTempFile($name) {
**[⬆ back to top](#table-of-contents)** **[⬆ back to top](#table-of-contents)**
### Avoid Side Effects ### Avoid Side Effects
A function produces a side effect if it does anything other than take a value in and A function produces a side effect if it does anything other than take a value in and
return another value or values. A side effect could be writing to a file, modifying return another value or values. A side effect could be writing to a file, modifying
some global variable, or accidentally wiring all your money to a stranger. some global variable, or accidentally wiring all your money to a stranger.
@@ -510,12 +511,14 @@ centralizing where your side effects occur. If you can do this, you will be happ
than the vast majority of other programmers. than the vast majority of other programmers.
**Bad:** **Bad:**
```php ```php
// Global variable referenced by following function. // Global variable referenced by following function.
// If we had another function that used this name, now it'd be an array and it could break it. // If we had another function that used this name, now it'd be an array and it could break it.
$name = 'Ryan McDermott'; $name = 'Ryan McDermott';
function splitIntoFirstAndLastName() { function splitIntoFirstAndLastName()
{
global $name; global $name;
$name = preg_split('/ /', $name); $name = preg_split('/ /', $name);
@@ -526,9 +529,11 @@ splitIntoFirstAndLastName();
var_dump($name); // ['Ryan', 'McDermott']; var_dump($name); // ['Ryan', 'McDermott'];
``` ```
**Good**: **Good:**
```php ```php
function splitIntoFirstAndLastName($name) { function splitIntoFirstAndLastName($name)
{
return preg_split('/ /', $name); return preg_split('/ /', $name);
} }
@@ -538,6 +543,7 @@ $newName = splitIntoFirstAndLastName($name);
var_dump($name); // 'Ryan McDermott'; var_dump($name); // 'Ryan McDermott';
var_dump($newName); // ['Ryan', 'McDermott']; var_dump($newName); // ['Ryan', 'McDermott'];
``` ```
**[⬆ back to top](#table-of-contents)** **[⬆ back to top](#table-of-contents)**
### Don't write to global functions ### Don't write to global functions