info/clean-code-php
1
0
Fork 0
mirror of https://github.com/jupeter/clean-code-php.git synced 2025-09-27 14:38:59 +02:00
Code Issues Releases Wiki Activity

Merge pull request #33 from peter-gribanov/encapsulate_conditionals2

Browse Source 
Encapsulate conditionals
This commit is contained in:
Tomáš Votruba
2017-08-31 19:49:18 +02:00
committed by GitHub
parent af83d6c05e dd259f3135
commit 399e3aa67b
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
README.md
View File

@@ -585,22 +585,21 @@ $singleton = Configuration::getInstance();
### Encapsulate conditionals ### Encapsulate conditionals
**Bad:** **Bad:**
```php ```php
if ($fsm->state === 'fetching' && is_empty($listNode)) { if ($article->state === 'published') {
// ... // ...
} }
``` ```
**Good**: **Good**:
```php
function shouldShowSpinner($fsm, $listNode) {
return $fsm->state === 'fetching' && is_empty($listNode);
}
if (shouldShowSpinner($fsmInstance, $listNodeInstance)) { ```php
// ... if ($article->isPublished()) {
// ...
} }
``` ```
**[⬆ back to top](#table-of-contents)** **[⬆ back to top](#table-of-contents)**
### Avoid negative conditionals ### Avoid negative conditionals