info/clean-code-php
1
0
Fork 0
mirror of https://github.com/jupeter/clean-code-php.git synced 2025-10-03 17:31:52 +02:00
Code Issues Releases Wiki Activity

Merge pull request #71 from peter-gribanov/avoid_conditionals_cs

Browse Source 
Correct CS in Avoid conditionals
This commit is contained in:
Tomáš Votruba
2017-09-05 18:16:09 +02:00
committed by GitHub
parent 794e0a236c 46a7f37104
commit 4cca1d1d4c
1 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
README.md
View File

@@ -720,6 +720,7 @@ if (isDOMNodePresent($node)) {
**[⬆ back to top](#table-of-contents)** **[⬆ back to top](#table-of-contents)**
### Avoid conditionals ### Avoid conditionals
This seems like an impossible task. Upon first hearing this, most people say, This seems like an impossible task. Upon first hearing this, most people say,
"how am I supposed to do anything without an `if` statement?" The answer is that "how am I supposed to do anything without an `if` statement?" The answer is that
you can use polymorphism to achieve the same task in many cases. The second you can use polymorphism to achieve the same task in many cases. The second
@@ -730,10 +731,14 @@ are telling your user that your function does more than one thing. Remember,
just do one thing. just do one thing.
**Bad:** **Bad:**
```php ```php
class Airplane { class Airplane
{
// ... // ...
public function getCruisingAltitude() {
public function getCruisingAltitude()
{
switch ($this->type) { switch ($this->type) {
case '777': case '777':
return $this->getMaxAltitude() - $this->getPassengerCount(); return $this->getMaxAltitude() - $this->getPassengerCount();
@@ -746,33 +751,45 @@ class Airplane {
} }
``` ```
**Good**: **Good:**
```php ```php
class Airplane { class Airplane
{
// ... // ...
} }
class Boeing777 extends Airplane { class Boeing777 extends Airplane
{
// ... // ...
public function getCruisingAltitude() {
public function getCruisingAltitude()
{
return $this->getMaxAltitude() - $this->getPassengerCount(); return $this->getMaxAltitude() - $this->getPassengerCount();
} }
} }
class AirForceOne extends Airplane { class AirForceOne extends Airplane
{
// ... // ...
public function getCruisingAltitude() {
public function getCruisingAltitude()
{
return $this->getMaxAltitude(); return $this->getMaxAltitude();
} }
} }
class Cessna extends Airplane { class Cessna extends Airplane
{
// ... // ...
public function getCruisingAltitude() {
public function getCruisingAltitude()
{
return $this->getMaxAltitude() - $this->getFuelExpenditure(); return $this->getMaxAltitude() - $this->getFuelExpenditure();
} }
} }
``` ```
**[⬆ back to top](#table-of-contents)** **[⬆ back to top](#table-of-contents)**
### Avoid type-checking (part 1) ### Avoid type-checking (part 1)