From cc9896241ae48a8ce1fb4e6f259b17a04990e5e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emin=20=C5=9Een?= Date: Sat, 2 Sep 2017 15:57:43 +0300 Subject: [PATCH 1/2] Duplicated fixes. Duplicate variables removed. Variable names updated. --- README.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 133914a..2ee3ae1 100644 --- a/README.md +++ b/README.md @@ -528,8 +528,6 @@ var_dump($name); // ['Ryan', 'McDermott']; **Good**: ```php -$name = 'Ryan McDermott'; - function splitIntoFirstAndLastName($name) { return preg_split('/ /', $name); } @@ -970,8 +968,9 @@ your codebase. ```php class UserSettings { private $user; + public function __construct($user) { - $this->user = user; + $this->user = $user; } public function changeSettings($settings) { @@ -990,8 +989,9 @@ class UserSettings { ```php class UserAuth { private $user; + public function __construct($user) { - $this->user = user; + $this->user = $user; } public function verifyCredentials() { @@ -1002,6 +1002,7 @@ class UserAuth { class UserSettings { private $user; + public function __construct($user) { $this->user = $user; $this->auth = new UserAuth($user); From c058329bff60ada383e5445ab3f30fbcc7ff50dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emin=20=C5=9Een?= Date: Sat, 2 Sep 2017 16:08:24 +0300 Subject: [PATCH 2/2] foreach loop syntax fixed. does not use "in" syntax, it uses "as" --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 2ee3ae1..ecab842 100644 --- a/README.md +++ b/README.md @@ -1186,12 +1186,12 @@ class Square extends Rectangle { } function renderLargeRectangles($rectangles) { - foreach($rectangle in $rectangles) { + foreach($rectangles as $rectangle) { $rectangle->setWidth(4); $rectangle->setHeight(5); $area = $rectangle->getArea(); // BAD: Will return 25 for Square. Should be 20. $rectangle->render($area); - }); + } } $rectangles = [new Rectangle(), new Rectangle(), new Square()]; @@ -1250,7 +1250,7 @@ class Square extends Shape { } function renderLargeRectangles($rectangles) { - foreach($rectangle in $rectangles) { + foreach($rectangles as $rectangle) { if ($rectangle instanceof Square) { $rectangle->setLength(5); } else if ($rectangle instanceof Rectangle) { @@ -1260,7 +1260,7 @@ function renderLargeRectangles($rectangles) { $area = $rectangle->getArea(); $rectangle->render($area); - }); + } } $shapes = [new Rectangle(), new Rectangle(), new Square()];