1
0
mirror of https://github.com/jupeter/clean-code-php.git synced 2025-09-28 15:09:00 +02:00
Commit Graph

279 Commits

Author SHA1 Message Date
Peter Gribanov
2a9cef3571 remove invalid comment 2017-09-05 19:43:35 +03:00
Tomáš Votruba
83146a7a26 Merge pull request #42 from peter-gribanov/isp
Interface Segregation Principle (ISP)
2017-09-05 18:36:38 +02:00
Peter Gribanov
7822f53254 Merge branch 'master' into isp 2017-09-05 19:35:39 +03:00
Tomáš Votruba
45b698a75a Merge pull request #62 from webaholik/patch-1
Update README.md
2017-09-05 18:19:04 +02:00
Tomáš Votruba
f59bb51cd4 Merge pull request #65 from alexislefebvre/patch-1
Restrict Method chaining to setters
2017-09-05 18:18:39 +02:00
Tomáš Votruba
9fd045b1b4 Merge pull request #67 from peter-gribanov/BetterJSAlternative_di
Remove introduction of mocking
2017-09-05 18:17:52 +02:00
Tomáš Votruba
d361e224d9 Merge pull request #72 from peter-gribanov/remove_dead_code_cs
Correct CS in Remove dead code
2017-09-05 18:16:35 +02:00
Tomáš Votruba
4682cd813b Merge pull request #68 from peter-gribanov/dont_use_flags_cs
Correct CS in Don't use flags as function parameters
2017-09-05 18:16:25 +02:00
Tomáš Votruba
809eee072c Merge pull request #69 from peter-gribanov/avoid_side_effects_cs
Correct CS in Avoid Side Effects
2017-09-05 18:16:18 +02:00
Tomáš Votruba
4cca1d1d4c Merge pull request #71 from peter-gribanov/avoid_conditionals_cs
Correct CS in Avoid conditionals
2017-09-05 18:16:09 +02:00
Tomáš Votruba
794e0a236c Merge pull request #70 from peter-gribanov/avoid_negative_conditionals_cs
Correct CS in Avoid negative conditionals
2017-09-05 18:15:59 +02:00
Tomáš Votruba
28aa87fddf Merge pull request #73 from peter-gribanov/objects_and_data_structures_cs
Correct CS in Objects and Data Structures
2017-09-05 18:15:46 +02:00
Tomáš Votruba
de9e99a455 Merge pull request #74 from peter-gribanov/private_protected_members_cs
Correct CS in Make objects have private/protected members
2017-09-05 18:14:52 +02:00
Peter Gribanov
bf037a3661 use PSR CS 2017-09-05 19:00:45 +03:00
Peter Gribanov
03af7a0896 use PSR CS 2017-09-05 18:56:35 +03:00
Peter Gribanov
b218f288c8 use PSR CS 2017-09-05 18:54:01 +03:00
Peter Gribanov
46a7f37104 use PSR CS 2017-09-05 18:51:33 +03:00
Peter Gribanov
fcdb1bb68a use PSR CS 2017-09-05 18:49:07 +03:00
Peter Gribanov
068bf035f9 use PSR CS 2017-09-05 18:40:18 +03:00
Peter Gribanov
0a5cb98bb0 use PSR CS 2017-09-05 18:36:34 +03:00
Peter Gribanov
9daf53d545 remove introduction of mocking 2017-09-05 17:27:09 +03:00
Tomáš Votruba
3d5a1b0fe8 Merge pull request #26 from peter-gribanov/default_arguments
[Bugfix] Use default arguments in PHP 7+
2017-09-05 14:10:38 +02:00
Peter Gribanov
aa24debbac Update README.md 2017-09-05 14:08:13 +03:00
Alexis Lefebvre
0368f8004a Restrict Method chaining to setters
Remove "I say" that adds no value
2017-09-05 12:24:02 +02:00
zouyi
dc63a3e0d1 add Translation section
add Translation section
2017-09-05 16:00:31 +08:00
webaholik
2570434657 Update README.md
Corrected a few words.
2017-09-04 22:27:15 -05:00
Tomáš Votruba
fd878a33f8 Merge pull request #58 from peter-gribanov/lsp
Liskov Substitution Principle (LSP)
2017-09-04 15:28:53 +02:00
Peter Gribanov
a71ad82a79 forgot ; 2017-09-04 13:06:19 +03:00
Peter Gribanov
32344ead21 correct access to $width and $height 2017-09-04 13:03:17 +03:00
Peter Gribanov
35e673e0ca Merge pull request #4 from jupeter/master
Update master
2017-09-04 12:58:46 +03:00
Tomáš Votruba
67e68e5cf1 Merge pull request #54 from EDDYMENS/master
fix typo
2017-09-04 11:01:17 +02:00
Tomáš Votruba
95f9f68d83 Merge pull request #56 from Zayon/patch-1
LSP good example correction
2017-09-04 11:00:39 +02:00
Pablo Godinez
6e01046113 LSP good example correction
See #55
2017-09-04 10:57:27 +02:00
Peter Gribanov
307a647f41 Merge branch 'master' into dip 2017-09-04 11:42:44 +03:00
eddymens
656e7ff6e6 fix typo 2017-09-04 08:21:53 +00:00
Tomáš Votruba
4be1dee2de Merge pull request #53 from emnsen/master
Fix variable spelling and syntax
2017-09-04 09:42:04 +02:00
Emin Şen
820a6a1d9e Fix variable spelling and syntax
Functions don't start with "new".
"$req" variable incorrect variable name, "$request" good.
Class construct syntax.
2017-09-04 04:58:47 +03:00
Tomáš Votruba
69222649e9 Merge pull request #52 from guilhermeportela/patch-1
Fix variable type in PHPDoc
2017-09-04 00:47:21 +02:00
Tomáš Votruba
9e8f2fd73e Merge pull request #49 from mstruebing/fix/matchersToMatches
Correct spelling
2017-09-04 00:46:54 +02:00
Tomáš Votruba
a64ad7fb87 Merge pull request #50 from emnsen/master
Duplicated fixes.
2017-09-04 00:46:07 +02:00
Guilherme Portela
0c89c48adb Fix variable type in PHPDoc 2017-09-03 10:20:14 -03:00
Emin Şen
c058329bff foreach loop syntax fixed.
does not use "in" syntax, it uses "as"
2017-09-02 16:08:24 +03:00
Emin Şen
cc9896241a Duplicated fixes.
Duplicate variables removed.
Variable names updated.
2017-09-02 15:57:43 +03:00
Max Strübing
1a0c0c0f56 Correct spelling 2017-09-02 11:31:49 +02:00
Tomáš Votruba
1db3e5301b Merge pull request #48 from litvinchuk/patch-2
Pass $name and $email to parent constructor in EmployeeTaxData
2017-09-01 22:09:20 +02:00
Tomáš Votruba
bfce179c28 Merge pull request #47 from ConnorVG/patch-1
Fix Invalid Code
2017-09-01 22:01:10 +02:00
Tomáš Votruba
cf1598f2b4 Merge pull request #39 from peter-gribanov/dry
Don't repeat yourself [DRY]
2017-09-01 17:16:41 +02:00
Peter Gribanov
08c8cc7b07 missing a second "e" at the end of employee 2017-09-01 18:02:30 +03:00
Peter Gribanov
2992a4f3fd remove Manager in ISP 2017-09-01 17:34:44 +03:00
Sergiy Litvinchuk
a77a62d7ce Pass $name and $email to parent constructor in EmployeeTaxData 2017-09-01 12:32:09 +03:00