info/developer-roadmap
1
0
Fork 0
mirror of https://github.com/kamranahmedse/developer-roadmap.git synced 2025-08-30 20:49:49 +02:00
Code Issues Releases Wiki Activity

Implement best-practice click handling

Browse Source
This commit is contained in:
Kamran Ahmed
2023-01-24 02:01:28 +04:00
parent 4711ab9a6f
commit c2dda3bc35
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/TopicOverlay/topic.js
View File

@@ -23,7 +23,7 @@ export class Topic {
this.handleOverlayClick = this.handleOverlayClick.bind(this); this.handleOverlayClick = this.handleOverlayClick.bind(this);
this.markAsDone = this.markAsDone.bind(this); this.markAsDone = this.markAsDone.bind(this);
this.markAsPending = this.markAsPending.bind(this); this.markAsPending = this.markAsPending.bind(this);
this.queryRoadmapElementsByTopicId = this.queryRoadmapElementsByTopicId.bind(this); this.querySvgElementsByTopicId = this.querySvgElementsByTopicId.bind(this);
this.rightClickListener = this.rightClickListener.bind(this); this.rightClickListener = this.rightClickListener.bind(this);
this.isTopicDone = this.isTopicDone.bind(this); this.isTopicDone = this.isTopicDone.bind(this);
@@ -150,8 +150,7 @@ export class Topic {
this.activeTopicId = topicId; this.activeTopicId = topicId;
this.resetDOM(); this.resetDOM();
this.renderTopicFromUrl(`/best-practices/${bestPracticeId}/${topicId.replaceAll(':', '/')}`);
alert('Best practices are not yet implemented!');
} }
handleRoadmapTopicClick(e) { handleRoadmapTopicClick(e) {
@@ -169,7 +168,7 @@ export class Topic {
this.renderTopicFromUrl(`/${roadmapId}/${topicId.replaceAll(':', '/')}`); this.renderTopicFromUrl(`/${roadmapId}/${topicId.replaceAll(':', '/')}`);
} }
queryRoadmapElementsByTopicId(topicId) { querySvgElementsByTopicId(topicId) {
const elements = document.querySelectorAll(`[data-group-id$="-${topicId}"]`); const elements = document.querySelectorAll(`[data-group-id$="-${topicId}"]`);
const matchingElements = []; const matchingElements = [];
@@ -189,7 +188,7 @@ export class Topic {
const updatedTopicId = topicId.replace(/^\d+-/, ''); const updatedTopicId = topicId.replace(/^\d+-/, '');
localStorage.setItem(updatedTopicId, 'done'); localStorage.setItem(updatedTopicId, 'done');
this.queryRoadmapElementsByTopicId(updatedTopicId).forEach((item) => { this.querySvgElementsByTopicId(updatedTopicId).forEach((item) => {
item?.classList?.add('done'); item?.classList?.add('done');
}); });
} }
@@ -198,7 +197,7 @@ export class Topic {
const updatedTopicId = topicId.replace(/^\d+-/, ''); const updatedTopicId = topicId.replace(/^\d+-/, '');
localStorage.removeItem(updatedTopicId); localStorage.removeItem(updatedTopicId);
this.queryRoadmapElementsByTopicId(updatedTopicId).forEach((item) => { this.querySvgElementsByTopicId(updatedTopicId).forEach((item) => {
item?.classList?.remove('done'); item?.classList?.remove('done');
}); });
} }