Add more tests

standalone/app/src/main/java/me/lucko/luckperms/standalone/app/LuckPermsApplication.java

@@ -130,6 +130,14 @@ public class LuckPermsApplication implements AutoCloseable {
         this.healthReporter = healthReporter;
     }
 
+    public CommandExecutor getCommandExecutor() {
+        return this.commandExecutor;
+    }
+
+    public HealthReporter getHealthReporter() {
+        return this.healthReporter;
+    }
+
     public String getVersion() {
         return "@version@";
     }

standalone/build.gradle

@@ -5,12 +5,25 @@ plugins {
 sourceCompatibility = 17
 targetCompatibility = 17
 
+test {
+    useJUnitPlatform {}
+}
+
 dependencies {
     implementation project(':common')
     compileOnly project(':common:loader-utils')
     compileOnly project(':standalone:app')
 
     compileOnly 'org.spongepowered:configurate-yaml:3.7.2'
+
+    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.9.1'
+    testImplementation 'org.junit.jupiter:junit-jupiter-engine:5.9.1'
+    testImplementation 'org.junit.jupiter:junit-jupiter-params:5.9.1'
+    testImplementation 'org.mockito:mockito-core:4.11.0'
+    testImplementation 'org.mockito:mockito-junit-jupiter:4.11.0'
+    testImplementation 'com.h2database:h2:2.1.214'
+    testImplementation project(':standalone:app')
+    testImplementation project(':common:loader-utils')
 }
 
 shadowJar {

standalone/src/main/java/me/lucko/luckperms/standalone/LPStandaloneBootstrap.java

@@ -36,6 +36,8 @@ import me.lucko.luckperms.standalone.app.LuckPermsApplication;
 
 import net.luckperms.api.platform.Platform;
 
+import org.jetbrains.annotations.VisibleForTesting;
+
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.time.Instant;
@@ -69,6 +71,21 @@ public class LPStandaloneBootstrap implements LuckPermsBootstrap, LoaderBootstra
         this.plugin = new LPStandalonePlugin(this);
     }
 
+    @VisibleForTesting
+    LPStandaloneBootstrap(LuckPermsApplication loader, ClassPathAppender classPathAppender) {
+        this.loader = loader;
+
+        this.logger = new Log4jPluginLogger(LuckPermsApplication.LOGGER);
+        this.schedulerAdapter = new StandaloneSchedulerAdapter(this);
+        this.classPathAppender = classPathAppender;
+        this.plugin = createTestPlugin();
+    }
+
+    @VisibleForTesting
+    LPStandalonePlugin createTestPlugin() {
+        return new LPStandalonePlugin(this);
+    }
+
     // provide adapters
 
     @Override

standalone/src/main/java/me/lucko/luckperms/standalone/StandaloneDependencyPreloader.java

@@ -29,6 +29,7 @@ import com.google.common.util.concurrent.ThreadFactoryBuilder;
 
 import me.lucko.luckperms.common.dependencies.Dependency;
 import me.lucko.luckperms.common.dependencies.DependencyManager;
+import me.lucko.luckperms.common.dependencies.DependencyManagerImpl;
 import me.lucko.luckperms.common.dependencies.relocation.RelocationHandler;
 import me.lucko.luckperms.common.util.MoreFiles;
 
@@ -54,7 +55,7 @@ public class StandaloneDependencyPreloader {
         MoreFiles.createDirectoriesIfNotExists(cacheDirectory);
 
         ExecutorService executorService = Executors.newFixedThreadPool(8, new ThreadFactoryBuilder().setDaemon(true).build());
-        DependencyManager dependencyManager = new DependencyManager(cacheDirectory, executorService);
+        DependencyManager dependencyManager = new DependencyManagerImpl(cacheDirectory, executorService);
 
         Set<Dependency> dependencies = new HashSet<>(Arrays.asList(Dependency.values()));
         System.out.println("Preloading " + dependencies.size() + " dependencies...");

standalone/src/test/java/me/lucko/luckperms/standalone/LPStandaloneTestBootstrap.java

@@ -0,0 +1,108 @@
+/*
+ * This file is part of LuckPerms, licensed under the MIT License.
+ *
+ *  Copyright (c) lucko (Luck) <luck@lucko.me>
+ *  Copyright (c) contributors
+ *
+ *  Permission is hereby granted, free of charge, to any person obtaining a copy
+ *  of this software and associated documentation files (the "Software"), to deal
+ *  in the Software without restriction, including without limitation the rights
+ *  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ *  copies of the Software, and to permit persons to whom the Software is
+ *  furnished to do so, subject to the following conditions:
+ *
+ *  The above copyright notice and this permission notice shall be included in all
+ *  copies or substantial portions of the Software.
+ *
+ *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ *  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ *  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ *  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ *  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ *  SOFTWARE.
+ */
+
+package me.lucko.luckperms.standalone;
+
+import me.lucko.luckperms.common.dependencies.Dependency;
+import me.lucko.luckperms.common.dependencies.DependencyManager;
+import me.lucko.luckperms.common.plugin.classpath.ClassPathAppender;
+import me.lucko.luckperms.common.storage.StorageType;
+import me.lucko.luckperms.standalone.app.LuckPermsApplication;
+
+import java.nio.file.Path;
+import java.util.Set;
+
+/**
+ * An extension standalone bootstrap for testing.
+ *
+ * <p>Key differences:</p>
+ * <p>
+ * <ul>
+ *     <li>Dependency loading system is replaced with a no-op stub that delegates to the test classloader</li>
+ *     <li>Translations aren't downloaded automatically</li>
+ * </ul>
+ * </p>
+ */
+public final class LPStandaloneTestBootstrap extends LPStandaloneBootstrap {
+    private static final ClassPathAppender NOOP_APPENDER = file -> {};
+
+    private final Path dataDirectory;
+    private LPStandaloneTestPlugin plugin;
+
+    LPStandaloneTestBootstrap(LuckPermsApplication app, Path dataDirectory) {
+        super(app, NOOP_APPENDER);
+        this.dataDirectory = dataDirectory;
+    }
+
+    public LPStandaloneTestPlugin getPlugin() {
+        return this.plugin;
+    }
+
+    @Override
+    public Path getDataDirectory() {
+        return this.dataDirectory;
+    }
+
+    @Override
+    LPStandalonePlugin createTestPlugin() {
+        System.setProperty("luckperms.auto-install-translations", "false");
+        this.plugin = new LPStandaloneTestPlugin(this);
+        return this.plugin;
+    }
+
+    static final class LPStandaloneTestPlugin extends LPStandalonePlugin {
+        LPStandaloneTestPlugin(LPStandaloneBootstrap bootstrap) {
+            super(bootstrap);
+        }
+
+        @Override
+        protected DependencyManager createDependencyManager() {
+            return new TestDependencyManager();
+        }
+    }
+
+    static final class TestDependencyManager implements DependencyManager {
+
+        @Override
+        public void loadDependencies(Set<Dependency> dependencies) {
+
+        }
+
+        @Override
+        public void loadStorageDependencies(Set<StorageType> storageTypes, boolean redis, boolean rabbitmq, boolean nats) {
+
+        }
+
+        @Override
+        public ClassLoader obtainClassLoaderWith(Set<Dependency> dependencies) {
+            return getClass().getClassLoader();
+        }
+
+        @Override
+        public void close() {
+
+        }
+    }
+}

standalone/src/test/java/me/lucko/luckperms/standalone/StandaloneIntegrationTests.java

@@ -0,0 +1,122 @@
+/*
+ * This file is part of LuckPerms, licensed under the MIT License.
+ *
+ *  Copyright (c) lucko (Luck) <luck@lucko.me>
+ *  Copyright (c) contributors
+ *
+ *  Permission is hereby granted, free of charge, to any person obtaining a copy
+ *  of this software and associated documentation files (the "Software"), to deal
+ *  in the Software without restriction, including without limitation the rights
+ *  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ *  copies of the Software, and to permit persons to whom the Software is
+ *  furnished to do so, subject to the following conditions:
+ *
+ *  The above copyright notice and this permission notice shall be included in all
+ *  copies or substantial portions of the Software.
+ *
+ *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ *  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ *  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ *  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ *  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ *  SOFTWARE.
+ */
+
+package me.lucko.luckperms.standalone;
+
+import me.lucko.luckperms.common.config.ConfigKeys;
+import me.lucko.luckperms.common.model.Group;
+import me.lucko.luckperms.common.node.types.Permission;
+import me.lucko.luckperms.standalone.app.LuckPermsApplication;
+import me.lucko.luckperms.standalone.app.integration.CommandExecutor;
+import me.lucko.luckperms.standalone.app.integration.HealthReporter;
+
+import net.luckperms.api.model.data.DataType;
+import net.luckperms.api.node.NodeEqualityPredicate;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * A set of 'integration tests' for the standalone LuckPerms app.
+ */
+public class StandaloneIntegrationTests {
+
+    private @TempDir Path tempDir;
+
+    @Test
+    public void testLoadEnableDisable() {
+        useTestPlugin((app, bootstrap, plugin) -> {
+            HealthReporter.Health health = app.getHealthReporter().poll();
+            assertNotNull(health);
+            assertTrue(health.isUp());
+        });
+    }
+
+    @Test
+    public void testRunCommand() {
+        useTestPlugin((app, bootstrap, plugin) -> {
+            CommandExecutor commandExecutor = app.getCommandExecutor();
+            commandExecutor.execute("group default permission set test").join();
+
+            Group group = bootstrap.getPlugin().getStorage().loadGroup("default").join().orElse(null);
+            assertNotNull(group);
+            assertTrue(group.hasNode(DataType.NORMAL, Permission.builder().permission("test").build(), NodeEqualityPredicate.EXACT).asBoolean());
+        });
+    }
+
+    @Test
+    public void testReloadConfig() throws IOException {
+        useTestPlugin((app, bootstrap, plugin) -> {
+            String server = plugin.getConfiguration().get(ConfigKeys.SERVER);
+            assertEquals("global", server);
+
+            Integer syncTime = plugin.getConfiguration().get(ConfigKeys.SYNC_TIME);
+            assertEquals(-1, syncTime);
+
+            Path config = this.tempDir.resolve("config.yml");
+            assertTrue(Files.exists(config));
+
+            String configString = Files.readString(config)
+                    .replace("server: global", "server: test")
+                    .replace("sync-minutes: -1", "sync-minutes: 10");
+            Files.writeString(config, configString);
+
+            plugin.getConfiguration().reload();
+
+            server = plugin.getConfiguration().get(ConfigKeys.SERVER);
+            assertEquals("test", server); // changed
+
+            syncTime = plugin.getConfiguration().get(ConfigKeys.SYNC_TIME);
+            assertEquals(-1, syncTime); // unchanged
+        });
+    }
+
+    private <E extends Throwable> void useTestPlugin(TestPluginConsumer<E> consumer) throws E {
+        LuckPermsApplication app = new LuckPermsApplication(() -> {});
+        LPStandaloneTestBootstrap bootstrap = new LPStandaloneTestBootstrap(app, this.tempDir);
+
+        bootstrap.onLoad();
+        bootstrap.onEnable();
+
+        try {
+            consumer.accept(app, bootstrap, bootstrap.getPlugin());
+        } finally {
+            bootstrap.onDisable();
+        }
+    }
+
+    interface TestPluginConsumer<E extends Throwable> {
+        void accept(LuckPermsApplication app, LPStandaloneTestBootstrap bootstrap, LPStandalonePlugin plugin) throws E;
+    }
+
+}

standalone/src/test/resources/log4j2.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Configuration status="warn" shutdownHook="disable">
+    <Appenders>
+        <TerminalConsole name="Console">
+            <PatternLayout pattern="%highlight{[%d{HH:mm:ss} %level]: %msg%n%xEx}"/>
+        </TerminalConsole>
+    </Appenders>
+
+    <Loggers>
+        <Root level="info">
+            <AppenderRef ref="Console"/>
+        </Root>
+    </Loggers>
+</Configuration>