mirror-games/dca3-game
1
0
Fork 0
mirror of https://gitlab.com/skmp/dca3-game.git synced 2025-08-22 14:22:58 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix UB

Browse Source
This commit is contained in:
aap
2020-12-31 16:14:46 +01:00
parent 77884e0a57
commit 1a8a1c91cb
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/weapons/Explosion.cpp
View File

@@ -104,7 +104,12 @@ CExplosion::AddExplosion(CEntity *explodingEntity, CEntity *culprit, eExplosionT
#endif #endif
int n = 0; int n = 0;
#ifdef FIX_BUGS
while (n < ARRAY_SIZE(gaExplosion) && gaExplosion[n].m_nIteration != 0)
#else
// array overrun is UB
while (gaExplosion[n].m_nIteration != 0 && n < ARRAY_SIZE(gaExplosion)) while (gaExplosion[n].m_nIteration != 0 && n < ARRAY_SIZE(gaExplosion))
#endif
n++; n++;
if (n == ARRAY_SIZE(gaExplosion)) if (n == ARRAY_SIZE(gaExplosion))
return false; return false;