- some bug fixes based on coverity scan

This commit is contained in:
SoftCoder
2015-11-25 21:16:29 -08:00
parent e7eddca1ee
commit 7e0494bb28
6 changed files with 58 additions and 51 deletions

View File

@@ -48,42 +48,50 @@ const char * getDialogCommand() {
file = popen("which zenity","r");
//printf("File #1 [%p]\n",file);
if (fgets(file_string, 100, file) != NULL ) {
pclose(file);
return "zenity";
}
else if (file != NULL) {
pclose(file);
if (file != NULL) {
if (fgets(file_string, 100, file) != NULL ) {
pclose(file);
return "zenity";
}
else {
pclose(file);
}
}
file = popen("which kdialog","r");
//printf("File #2 [%p]\n",file);
if (fgets(file_string, 100, file) != NULL ) {
pclose(file);
return "kdialog";
}
else if (file != NULL) {
pclose(file);
if (file != NULL) {
if (fgets(file_string, 100, file) != NULL ) {
pclose(file);
return "kdialog";
}
else {
pclose(file);
}
}
file = popen("which yad","r");
//printf("File #3 [%p]\n",file);
if (fgets(file_string, 100, file) != NULL ) {
pclose(file);
return "yad";
}
else if (file != NULL) {
pclose(file);
if (file != NULL) {
if (fgets(file_string, 100, file) != NULL ) {
pclose(file);
return "yad";
}
else {
pclose(file);
}
}
file = popen("which gdialog","r");
//printf("File #4 [%p]\n",file);
if (fgets(file_string, 100, file) != NULL ) {
pclose(file);
return "gdialog";
}
else if (file != NULL) {
pclose(file);
if (file != NULL) {
if (fgets(file_string, 100, file) != NULL ) {
pclose(file);
return "gdialog";
}
else {
pclose(file);
}
}
return NULL;

View File

@@ -247,8 +247,8 @@ void Thread::start() {
BaseThread *base_thread = dynamic_cast<BaseThread *>(this);
if(base_thread) base_thread->setStarted(true);
thread = SDL_CreateThread(beginExecution, base_thread->getUniqueID().c_str(), this);
string uniqueId = base_thread->getUniqueID();
thread = SDL_CreateThread(beginExecution, uniqueId.c_str(), this);
if(thread == NULL) {
if(base_thread) base_thread->setStarted(false);

View File

@@ -656,10 +656,6 @@ void Window::handleMouseWheel(SDL_Event event) {
// // movement is 120.
eventMouseWheel(x, y, event.wheel.y * 120);
return;
if (SystemFlags::getSystemSettingType(SystemFlags::debugSystem).enabled)
SystemFlags::OutputDebug(SystemFlags::debugSystem,"In [%s::%s Line: %d]\n",extractFileFromDirectoryPath(__FILE__).c_str(),__FUNCTION__,__LINE__);
}
void Window::handleMouseDown(SDL_Event event) {