mirror-games/glest-source
1
0
Fork 0
mirror of https://github.com/glest/glest-source.git synced 2025-08-20 23:21:19 +02:00
Code Issues Projects Releases Wiki Activity

add more unit tests to cover all of the xml parser code

Browse Source
This commit is contained in:
Mark Vejvoda
2013-05-28 20:56:01 +00:00
parent 831bbda6c9
commit 9ef098ba02
2 changed files with 182 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/shared_lib/sources/xml/xml_parser.cpp
View File

@@ -876,6 +876,10 @@ string XmlNode::getTreeString() const {
// =====================================================
XmlAttribute::XmlAttribute(DOMNode *attribute, const std::map<string,string> &mapTagReplacementValues) {
if(attribute == NULL || attribute->getNodeName() == NULL) {
throw megaglest_runtime_error("XML attribute seems to be corrupt!");
}
skipRestrictionCheck = false;
usesCommondata = false;
this->mapTagReplacementValues = mapTagReplacementValues;
@@ -891,6 +895,10 @@ XmlAttribute::XmlAttribute(DOMNode *attribute, const std::map<string,string> &ma
}
XmlAttribute::XmlAttribute(xml_attribute<> *attribute, const std::map<string,string> &mapTagReplacementValues) {
if(attribute == NULL || attribute->name() == NULL) {
throw megaglest_runtime_error("XML attribute seems to be corrupt!");
}
skipRestrictionCheck = false;
usesCommondata = false;
if(mapTagReplacementValues.size() > 0) {
@@ -954,6 +962,7 @@ float XmlAttribute::getFloatValue() const{
float XmlAttribute::getFloatValue(float min, float max) const{
float f= strToFloat(value);
//printf("getFloatValue f = %.10f [%s]\n",f,value.c_str());
if(f<min || f>max){
throw megaglest_runtime_error("Xml attribute float out of range: " + getName() + ": " + value);
}