From acaed84ab249f6f87d62d674bc4e78d67fbfff55 Mon Sep 17 00:00:00 2001 From: Mitch Bradley Date: Thu, 1 Jul 2021 19:45:22 -1000 Subject: [PATCH] I2SO works with this fix It removes the delay from I2SOPinDetail::write, which was causing crashes when it was called via step(). The delay messed up the ISR. --- Grbl_Esp32/src/Pins/I2SOPinDetail.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Grbl_Esp32/src/Pins/I2SOPinDetail.cpp b/Grbl_Esp32/src/Pins/I2SOPinDetail.cpp index 51cab9d1..a79284ef 100644 --- a/Grbl_Esp32/src/Pins/I2SOPinDetail.cpp +++ b/Grbl_Esp32/src/Pins/I2SOPinDetail.cpp @@ -53,10 +53,6 @@ namespace Pins { void I2SOPinDetail::write(int high) { int value = _readWriteMask ^ high; i2s_out_write(_index, value); - // XXX Do we want to add i2s_out_delay() here ? - // Doing so would eliminate the need to override - // switchCSpin() in TrinamicDriver.cpp - i2s_out_delay(); } int I2SOPinDetail::read() {