From 74386631e0b6f25f24abc01190b0c813e0d576eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tam=C3=A1s=20B=C3=A1lint=20Misius?= Date: Wed, 20 Nov 2024 21:27:02 +0100 Subject: [PATCH] Fix crash on exit while there are Lua windows visible Broken since 02b679aec37f, where GameView started popping everything above itself before popping itself. The problem was that LSI would get destroyed before GameView did this, but popping Lua windows needed LSI to be alive still. --- src/gui/game/GameController.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gui/game/GameController.cpp b/src/gui/game/GameController.cpp index 9cbf16a69..1ed972d48 100644 --- a/src/gui/game/GameController.cpp +++ b/src/gui/game/GameController.cpp @@ -147,10 +147,10 @@ GameController::~GameController() { delete *iter; } - commandInterface.reset(); - delete gameModel; gameView->CloseActiveWindow(); delete gameView; + commandInterface.reset(); + delete gameModel; } bool GameController::HistoryRestore()