mirror/bsnes
1
0
Fork 0
mirror of https://github.com/bsnes-emu/bsnes.git synced 2025-09-03 10:42:46 +02:00
Code Issues Projects Releases Wiki Activity

Fix HDMA5 not being correctly updated in memory when disabling hblank HDMA

Browse Source
This commit is contained in:
Lior Halphon
2023-12-09 15:54:57 +02:00
parent b51aac4bf5
commit 1c0f65177f
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Core/memory.c
View File

@@ -1678,6 +1678,7 @@ static void write_high_memory(GB_gameboy_t *gb, uint16_t addr, uint8_t value)
return; return;
case GB_IO_HDMA5: case GB_IO_HDMA5:
if (!gb->cgb_mode) return; if (!gb->cgb_mode) return;
gb->hdma_steps_left = (value & 0x7F) + 1;
if ((value & 0x80) == 0 && gb->hdma_on_hblank) { if ((value & 0x80) == 0 && gb->hdma_on_hblank) {
gb->hdma_on_hblank = false; gb->hdma_on_hblank = false;
return; return;
@@ -1687,8 +1688,6 @@ static void write_high_memory(GB_gameboy_t *gb, uint16_t addr, uint8_t value)
if (gb->hdma_on_hblank && (gb->io_registers[GB_IO_STAT] & 3) == 0 && gb->display_state != 7) { if (gb->hdma_on_hblank && (gb->io_registers[GB_IO_STAT] & 3) == 0 && gb->display_state != 7) {
gb->hdma_on = true; gb->hdma_on = true;
} }
gb->io_registers[GB_IO_HDMA5] = value;
gb->hdma_steps_left = (gb->io_registers[GB_IO_HDMA5] & 0x7F) + 1;
return; return;
/* TODO: What happens when starting a transfer during external clock? /* TODO: What happens when starting a transfer during external clock?
@@ -1918,7 +1917,6 @@ void GB_hdma_run(GB_gameboy_t *gb)
if (--gb->hdma_steps_left == 0 || gb->hdma_current_dest == 0) { if (--gb->hdma_steps_left == 0 || gb->hdma_current_dest == 0) {
gb->hdma_on = false; gb->hdma_on = false;
gb->hdma_on_hblank = false; gb->hdma_on_hblank = false;
gb->io_registers[GB_IO_HDMA5] &= 0x7F;
} }
else if (gb->hdma_on_hblank) { else if (gb->hdma_on_hblank) {
gb->hdma_on = false; gb->hdma_on = false;