mirror/devicon
1
0
Fork 0
mirror of https://github.com/konpa/devicon.git synced 2025-08-30 17:50:35 +02:00
Code Issues Releases Wiki Activity

New Feature: Upgrade Peekbot (#966)

Browse Source 
* Moved stroke detection down

* Add code to retry no connection in peekbot

* Change upload artifact to earlier version

* Clean up logging msg

* Add ability to customize port number

* Update Selenium and geckodriver

* Move upload-artifact version to 2.2.4

* Add logging for webdriver retry

* Add color checking to peek-bot
This commit is contained in:
Thomas Bui
2021-12-21 12:33:41 -08:00
committed by GitHub
parent 34a54bcf1a
commit 2a8c499605
9 changed files with 112 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
.github/workflows/peek_icons.yml vendored
View File

@@ -30,7 +30,7 @@ jobs:
run: echo $PR_NUM > pr_num.txt
- name: Upload the PR number
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v2.2.4
with:
name: pr_num
path: ./pr_num.txt
@@ -41,25 +41,25 @@ jobs:
shell: cmd
run: >
python ./.github/scripts/icomoon_peek.py
./.github/scripts/build_assets/geckodriver-v0.29.1-win64/geckodriver.exe ./icomoon.json
./.github/scripts/build_assets/geckodriver-v0.30.0-win64/geckodriver.exe ./icomoon.json
./devicon.json ./icons ./ --headless --pr_title "%PR_TITLE%"
- name: Upload the err messages (created by icomoon_peek.py)
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v2.2.4
if: always()
with:
name: err_messages
path: ./err_messages.txt
- name: Upload screenshots for comments
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v2.2.4
if: success()
with:
name: screenshots
path: ./screenshots/*.png
- name: Upload geckodriver.log for debugging purposes
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v2.2.4
if: failure()
with:
name: geckodriver-log

29
.github/workflows/post_peek_screenshot.yml vendored
View File

@@ -72,6 +72,14 @@ jobs:
path: ./screenshots/new_icon_*.png
client_id: ${{secrets.IMGUR_CLIENT_ID}}
- name: Upload zoomed in screenshot of the colored icons gotten from the artifacts
id: colored_icons_detailed_img_step
uses: devicons/public-upload-to-imgur@v2.2.2
if: env.PEEK_STATUS == 'success' && success()
with:
path: ./screenshots/new_colored_icon_*.png
client_id: ${{secrets.IMGUR_CLIENT_ID}}
- name: Comment on the PR about the result - Success
uses: jungwinter/comment@v1 # let us comment on a specific PR
if: env.PEEK_STATUS == 'success' && success()
@@ -80,20 +88,22 @@ jobs:
Hi there,
I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using [icomoon.io](https://icomoon.io/app/#/select).
{0}
Here are the SVGs as intepreted by Icomoon when we upload the files:
{0}
Here are the zoomed-in screenshots of the added icons as **SVGs**:
{1}
Here are the zoomed-in screenshots of the added icons as **SVGs**. This is how Icomoon intepret the uploaded SVGs:
Here are the icons that will be generated by Icomoon:
{2}
Here are the icons that will be generated by Icomoon:
Here are the zoomed-in screenshots of the added icons as **icons**:
{3}
Here are the zoomed-in screenshots of the added icons as **icons**. This is what the font will look like:
Here are the colored versions:
{4}
You can click on the pictures and zoom on them if needed.
{5}
The maintainers will now check for:
1. The number of Glyphs matches the number of SVGs that were selected.
@@ -104,7 +114,7 @@ jobs:
Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.
Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.
Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.
Cheers,
Peek Bot :blush:
@@ -116,11 +126,12 @@ jobs:
${{
format(
env.MESSAGE,
steps.err_message_reader.outputs.content,
fromJSON(steps.svgs_overview_img_step.outputs.markdown_urls)[0],
join(fromJSON(steps.svgs_detailed_img_step.outputs.markdown_urls), ' '),
fromJSON(steps.icons_overview_img_step.outputs.markdown_urls)[0],
join(fromJSON(steps.icons_detailed_img_step.outputs.markdown_urls), ' ')
join(fromJSON(steps.icons_detailed_img_step.outputs.markdown_urls), ' '),
join(fromJSON(steps.colored_icons_detailed_img_step.outputs.markdown_urls), ' '),
steps.err_message_reader.outputs.content
)
}}