From 300685abbff402a2b9f8f7bf25045d284dc82b68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Kalsnes=20Hagen?= <43886029+Snailedlt@users.noreply.github.com> Date: Sun, 11 Dec 2022 18:10:04 +0100 Subject: [PATCH] Add alphabetical ordering of `devicon.json` to PR checklist (#1332) * Add note to maintainers about checking devicon.json related #1327 * implement suggest changes from PR reviews * fix updating devicon.json wiki link --- .github/PULL_REQUEST_TEMPLATE/new_icon.md | 2 +- .github/workflows/post_peek_screenshot.yml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/new_icon.md b/.github/PULL_REQUEST_TEMPLATE/new_icon.md index 43ed7300..bcc4f6a7 100644 --- a/.github/PULL_REQUEST_TEMPLATE/new_icon.md +++ b/.github/PULL_REQUEST_TEMPLATE/new_icon.md @@ -6,7 +6,7 @@ - [ ] PR's base is the `develop` branch. - [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/wiki/Organizing-SVGs) - [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/wiki/SVG-Standards) -- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60) +- [ ] A new object is added in the `devicon.json` file at the correct alphabetic position as seen [here](https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60) diff --git a/.github/workflows/post_peek_screenshot.yml b/.github/workflows/post_peek_screenshot.yml index 5a8ea96a..22528454 100644 --- a/.github/workflows/post_peek_screenshot.yml +++ b/.github/workflows/post_peek_screenshot.yml @@ -109,6 +109,7 @@ jobs: 1. The number of Glyphs matches the number of SVGs that were selected. 2. The icons (second group of pictures) look the same as the SVGs (first group of pictures). 3. The icons are of high quality (legible, matches the official logo, etc.) + 4. A new object is added in the `devicon.json` file at the correct alphabetic position as seen [here](https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60) In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this [doc](https://icomoon.io/#faq/importing) for more details and fix the issues as instructed by Icomoon and update this PR once you are done. @@ -151,7 +152,7 @@ jobs: Make sure that: - Your SVGs are named and added correctly to the /icons folder as seen [here](https://github.com/devicons/devicon/wiki/Organizing-SVGs). - - Your icon information has been added to the `devicon.json` as seen [here](https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60) + - Your icon information has been added to the `devicon.json` as seen [here](https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60) - Your PR title follows the format seen [here](https://github.com/devicons/devicon/wiki/Overview-on-Submitting-Icons) I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.