mirror of
https://github.com/konpa/devicon.git
synced 2025-08-13 10:04:24 +02:00
Fix check icon not running for update icon pr (#1060)
This commit is contained in:
4
.github/scripts/icomoon_build.py
vendored
4
.github/scripts/icomoon_build.py
vendored
@@ -56,7 +56,7 @@ def main():
|
||||
|
||||
print("Task completed.")
|
||||
except TimeoutException as e:
|
||||
util.exit_with_err("Selenium Time Out Error: \n" + str(e))
|
||||
util.exit_with_err(Exception("Selenium Time Out Error: \n" + str(e)))
|
||||
except Exception as e:
|
||||
util.exit_with_err(e)
|
||||
finally:
|
||||
@@ -95,7 +95,7 @@ def get_icons_for_building(icomoon_json_path: str, devicon_json_path: str, token
|
||||
return new_icons
|
||||
|
||||
|
||||
def optimize_svgs(new_icons: List[str], icons_folder_path: str):
|
||||
def optimize_svgs(new_icons: List[dict], icons_folder_path: str):
|
||||
"""
|
||||
Optimize the newly added svgs. This is done in batches
|
||||
since the command line has a limit on characters allowed.
|
||||
|
2
.github/workflows/check_icon_pr.yml
vendored
2
.github/workflows/check_icon_pr.yml
vendored
@@ -4,7 +4,7 @@ jobs:
|
||||
check:
|
||||
name: Check the `devicon.json` and the SVGs' quality
|
||||
runs-on: ubuntu-18.04
|
||||
if: startsWith(github.event.pull_request.title, 'new icon') # only checks icon PR
|
||||
if: startsWith(github.event.pull_request.title, 'new icon') || startsWith(github.event.pull_request.title, 'update icon') # only checks icon PR
|
||||
steps:
|
||||
- uses: actions/checkout@v2
|
||||
|
||||
|
Reference in New Issue
Block a user