mirror/devicon
1
0
Fork 0
mirror of https://github.com/konpa/devicon.git synced 2025-08-17 03:54:05 +02:00
Code Issues Releases Wiki Activity

Create a general pull_request_template.md (#703)

Browse Source 
* Create a general pull_request_template.md

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>

* Add line about base of PR in pr template

* Update PR and Issue templates

* Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md

Good idea

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update .github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md

Co-authored-by: David Leal <halfpacho@gmail.com>

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>
This commit is contained in:
Thomas Bui
2021-07-05 18:35:15 -07:00
committed by GitHub
parent b13b02d019
commit 3e90d55653
8 changed files with 100 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
.github/drafts/PULL_REQUEST_TEMPLATE/new_feature.md vendored Normal file
View File

@@ -0,0 +1,24 @@
---
name: New Feature
about: Add a new feature to the repository.
title: 'New Feature: [NAME]'
labels: 'enhancement'
assignees: ''
---
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. -->
## Double check these details before you open a PR**
<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *New Feature: brief description of feature*
## This PR adds/fixes...
<!-- List your features here and the benefits they bring. -->
## Notes
<!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). -->

23
.github/drafts/PULL_REQUEST_TEMPLATE/new_icon.md vendored Normal file
View File

@@ -0,0 +1,23 @@
---
name: New Icon
about: Add a new icon to the repository.
title: 'new icon: [NAME] (versions)'
labels: 'feature:icon'
assignees: ''
---
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. -->
## Double check these details before you open a PR
<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
- [] PR's base is the `develop` branch.
- [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
- [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
- [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->
## Link to prove your SVG is correct and up-to-date.
<!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. -->