From 4001786082665b8ce7e5fbd6ad1107bc34af8be4 Mon Sep 17 00:00:00 2001 From: Thomas Bui Date: Thu, 15 Oct 2020 21:38:53 -0700 Subject: [PATCH] Fixed an error where last commit didn't have desired changes --- .github/workflows/peek_icons.yml | 19 +------------------ CONTRIBUTING.md | 2 +- 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/.github/workflows/peek_icons.yml b/.github/workflows/peek_icons.yml index 36773443..5ebfa8a1 100644 --- a/.github/workflows/peek_icons.yml +++ b/.github/workflows/peek_icons.yml @@ -37,21 +37,4 @@ jobs: if: ${{success()}} with: name: new_icons - path: ./new_icons.png - - name: Pull Request Add Comment - uses: actions/github-script@0.3.0 - env: - message: > - Hi! I'm Devicons' GitHub Actions Bot! - - I just peeked at the icons that you wanted to add and upload them to the - [Actions page](https://github.com/devicons/devicon/actions). The maintainers - will now take a look at it and decide whether to merge your PR. - - Cheers :), - Bot - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - script: | - const { issue: { number: pr_number }, repo: { owner, repo } } = context; - github.issues.createComment({ pr_number, owner, repo, body: '$message' }); + path: ./new_icons.png \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a630e382..c58f6c28 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -63,7 +63,7 @@ Some icons are really simple (like the Apple one), so the original version can b
  • The plain and line versions (with or without wordmark) need to stay as simple as possible. They must have only one color and the paths are united before exporting to svg.
  • Optimize/compress your SVGs. You can use a service like compressor or SVG Editor.
    • -
  • +
  • The icon's strokes and texts must be fills. We use Icomoon to make our icon, which has its requirements