diff --git a/.github/scripts/build_assets/util.py b/.github/scripts/build_assets/util.py index a9f5a109..a4c0c755 100644 --- a/.github/scripts/build_assets/util.py +++ b/.github/scripts/build_assets/util.py @@ -75,3 +75,7 @@ valid_svg_filename_pattern = re.compile(r"-(original|plain|line)(-wordmark)?\.sv def is_svg_name_valid(filename: str): return valid_svg_filename_pattern.search(filename) is not None +valid_svg_version_pattern = re.compile(r"^(original|plain|line)(-wordmark)?$") +def is_svg_version_valid(version): + return valid_svg_version_pattern.search(version) is not None + diff --git a/.github/scripts/check_icon_pr.py b/.github/scripts/check_icon_pr.py index 90444068..40c6fe13 100644 --- a/.github/scripts/check_icon_pr.py +++ b/.github/scripts/check_icon_pr.py @@ -82,7 +82,7 @@ def check_devicon_object(icon: dict): err_msgs.append("- must contain at least 1 svg version in a list.") for version in icon["versions"]["svg"]: - if not util.is_svg_name_valid(version): + if not util.is_svg_version_valid(version): err_msgs.append(f"- Invalid version name in versions['svg']: '{version}'. Must match regexp: (original|plain|line)(-wordmark)?") except KeyError: err_msgs.append("- missing key: 'svg' in 'versions'.") @@ -92,7 +92,7 @@ def check_devicon_object(icon: dict): err_msgs.append("- must contain at least 1 font version in a list.") for version in icon["versions"]["font"]: - if not util.is_svg_name_valid(version): + if not util.is_svg_version_valid(version): err_msgs.append(f"- Invalid version name in versions['font']: '{version}'. Must match regexp: (original|plain|line)(-wordmark)?") except KeyError: err_msgs.append("- missing key: 'font' in 'versions'.")