From 95655797af77369c741b1ee9312551b3047fbde2 Mon Sep 17 00:00:00 2001
From: Thomas Bui <thomasbui198@gmail.com>
Date: Fri, 16 Oct 2020 18:27:04 -0700
Subject: [PATCH] Added a comment action and fix async issue in python script

---
 .github/scripts/build_assets/SeleniumRunner.py | 13 +++++++++++--
 .github/workflows/peek_icons.yml               | 17 ++++-------------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/.github/scripts/build_assets/SeleniumRunner.py b/.github/scripts/build_assets/SeleniumRunner.py
index 596ea5b4..4c659a2b 100644
--- a/.github/scripts/build_assets/SeleniumRunner.py
+++ b/.github/scripts/build_assets/SeleniumRunner.py
@@ -75,6 +75,14 @@ class SeleniumRunner:
         self.driver = WebDriver(options=options, executable_path=geckodriver_path)
         self.driver.get(self.ICOMOON_URL)
         assert "IcoMoon App" in self.driver.title
+        
+        # wait until the whole web page is loaded by testing the hamburger input
+        hamburger_input = WebDriverWait(self.driver, SeleniumRunner.LONG_WAIT_IN_SEC).until(
+            ec.element_to_be_clickable((By.CSS_SELECTOR,
+                "button.btn5.lh-def.transparent i.icon-menu"))
+        )
+        hamburger_input.click()
+        print("Accessed icomoon.io")
 
     def upload_icomoon(self, icomoon_json_path: str):
         """
@@ -86,7 +94,7 @@ class SeleniumRunner:
         try:
             # find the file input and enter the file path
             import_btn = WebDriverWait(self.driver, SeleniumRunner.LONG_WAIT_IN_SEC).until(
-                ec.presence_of_element_located((By.CSS_SELECTOR, "div#file input"))
+                ec.element_to_be_clickable((By.CSS_SELECTOR, "div#file input"))
             )
             import_btn.send_keys(icomoon_json_path)
         except Exception as e:
@@ -138,6 +146,7 @@ class SeleniumRunner:
                 ec.element_to_be_clickable((By.XPATH, "//button[text()='Select All']"))
             )
             select_all_button.click()
+            print("Finished uploading the svgs...")
         except Exception as e:
             self.close()
             raise e
@@ -155,7 +164,7 @@ class SeleniumRunner:
             )
 
             menu_appear_callback = ec.element_to_be_clickable(
-                (By.CSS_SELECTOR, "h1#setH2 ul")
+                (By.CSS_SELECTOR, "h1 ul.menuList2")
             )
 
             while not menu_appear_callback(self.driver):
diff --git a/.github/workflows/peek_icons.yml b/.github/workflows/peek_icons.yml
index f1a27edd..30bacbb9 100644
--- a/.github/workflows/peek_icons.yml
+++ b/.github/workflows/peek_icons.yml
@@ -21,15 +21,9 @@ jobs:
           python -m pip install --upgrade pip
           pip install -r ./.github/scripts/requirements.txt
           npm install
-<<<<<<< HEAD
       - name: Run icomoon_peek.py
         run: >
           python ./.github/scripts/icomoon_peek.py 
-=======
-      - name: Run icomoon_upload.py
-        run: >
-          python ./.github/scripts/icomoon_upload.py 
->>>>>>> 89412c2... Added a peek script
           ./.github/scripts/build_assets/geckodriver-v0.27.0-win64/geckodriver.exe
           ./icomoon.json ./devicon.json ./icons ./ --headless
       - name: Upload geckodriver.log for debugging purposes
@@ -43,14 +37,12 @@ jobs:
         if: ${{success()}}
         with:
           name: new_icons
-<<<<<<< HEAD
           path: ./new_icons.png
-=======
-          path: ./new_icons.png
-      - name: Create a comment alerting that the bot peeked
-        uses: peter-evans/commit-comment@v1
+      - name: Comment on the PR about the result
+        uses: github-actions-up-and-running/pr-comment@v1.0.1
         with:
-          body: >
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          message: >
             Hi! I'm Devicons' GitHub Actions Bot!
             
             I just peeked at the icons that you wanted to add and upload them to the 
@@ -59,4 +51,3 @@ jobs:
 
             Cheers :),
             Bot
->>>>>>> 89412c2... Added a peek script