mirror of
https://github.com/konpa/devicon.git
synced 2025-08-11 17:14:27 +02:00
Major build improvements (#1668)
* Major build improvements * Cleanup and fix path * chore: apply suggestions from code review Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Remove `selenium` from the NPM dependencies * Revert `nano` icon changes * Use quote notes * Update * chore: apply suggestions from code review Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Snailedlt/improve build changes (#187) * Make README more readable * move logic from index.html to script.js * fix devicon min css in head * Fix build script missing token error * Add more print statements to local build script * Change from ng-href to href in code view * Minor readme improvements --------- Co-authored-by: David Leal <halfpacho@gmail.com> --------- Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
This commit is contained in:
4
.github/scripts/build_assets/arg_getters.py
vendored
4
.github/scripts/build_assets/arg_getters.py
vendored
@@ -2,7 +2,7 @@ from argparse import ArgumentParser
|
||||
from build_assets.PathResolverAction import PathResolverAction
|
||||
|
||||
|
||||
def get_selenium_runner_args(peek_mode=False):
|
||||
def get_selenium_runner_args(has_token=True, peek_mode=False):
|
||||
"""
|
||||
Get the commandline arguments for the icomoon_peek.py and
|
||||
icomoon_build.py.
|
||||
@@ -36,7 +36,7 @@ def get_selenium_runner_args(peek_mode=False):
|
||||
if peek_mode:
|
||||
parser.add_argument("pr_title",
|
||||
help="The title of the PR that we are peeking at")
|
||||
else:
|
||||
if has_token != False:
|
||||
parser.add_argument("token",
|
||||
help="The GitHub token to access the GitHub REST API.")
|
||||
|
||||
|
Reference in New Issue
Block a user