mirror/devicon
1
0
Fork 0
mirror of https://github.com/konpa/devicon.git synced 2025-08-13 10:04:24 +02:00
Code Issues Releases Wiki Activity

Updated file names in check_svgs_on_pr

Browse Source
This commit is contained in:
Thomas Bui
2021-01-08 15:53:42 -08:00
parent b1922925b7
commit c9b19346b2
6 changed files with 26 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.github/scripts/build_assets/arg_getters.py vendored
View File

@@ -45,8 +45,12 @@ def get_check_svgs_on_pr_args():
Get the commandline arguments for the check_svgs_on_pr.py.
"""
parser = ArgumentParser(description="Check the SVGs to ensure their attributes are correct. Run whenever a PR is opened")
parser.add_argument("files_changed_json_path",
help="The path to the files.json created by the gh-action-get-changed-files@2.1.4",
parser.add_argument("files_added_json_path",
help="The path to the files_added.json created by the gh-action-get-changed-files@2.1.4",
action=PathResolverAction)
parser.add_argument("files_modified_json_path",
help="The path to the files_modified.json created by the gh-action-get-changed-files@2.1.4",
action=PathResolverAction)
return parser.parse_args()

27
.github/scripts/build_assets/filehandler.py vendored
View File

@@ -207,23 +207,26 @@ def create_screenshot_folder(dir, screenshot_name: str="screenshots/"):
finally:
return str(screenshot_folder)
def get_added_modified_svgs(files_changed_json_path: str):
def get_added_modified_svgs(files_added_json_path: str,
files_modified_json_path: str):
"""
Get the svgs added and modified from the files_changed_json_path.
:param: the path to the files.json created by the gh-action-get-changed-files@2.1.4
:return: a list of the svg file paths that were added/modified in this pr.
:param: files_added_json_path, the path to the files_added.json created by the gh-action-get-changed-files@2.1.4
:param: files_modified_json_path, the path to the files_modified.json created by the gh-action-get-changed-files@2.1.4
:return: a list of the svg file paths that were added/modified in this pr as Path.
"""
files_dict = get_json_file_content(files_changed_json_path)
print(files_dict)
svgs = []
for file in files_dict["added"]:
path = Path(file)
if path.suffix.lower() == ".svg":
svgs.append(file)
files_added = get_json_file_content(files_added_json_path)
files_modified = get_json_file_content(files_modified_json_path)
for file in files_dict["modified"]:
svgs = []
for file in files_added:
path = Path(file)
if path.suffix.lower() == ".svg":
svgs.append(file)
svgs.append(path)
for file in files_modified:
path = Path(file)
if path.suffix.lower() == ".svg":
svgs.append(path)
return svgs

2
.github/scripts/build_assets/util.py vendored
View File

@@ -13,7 +13,7 @@ def exit_with_err(err: Exception):
:param: err, the error/exception encountered.
"""
traceback.print_exc()
sys.exit(str(err))
sys.exit(1)
def check_svgs(svg_file_paths: List[Path]):