mirror of
https://github.com/konpa/devicon.git
synced 2025-08-09 08:06:32 +02:00
Build script now run manually
This commit is contained in:
8
.github/workflows/build_icons.yml
vendored
8
.github/workflows/build_icons.yml
vendored
@@ -1,11 +1,8 @@
|
|||||||
name: Build Icons
|
name: Build Icons
|
||||||
on:
|
on: workflow_dispatch
|
||||||
pull_request:
|
|
||||||
types: [labeled]
|
|
||||||
jobs:
|
jobs:
|
||||||
build:
|
build:
|
||||||
name: Get Fonts From Icomoon
|
name: Get Fonts From Icomoon
|
||||||
if: contains(github.event.pull_request.labels.*.name, 'bot:build')
|
|
||||||
runs-on: windows-2019
|
runs-on: windows-2019
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- uses: actions/checkout@v2
|
||||||
@@ -46,7 +43,8 @@ jobs:
|
|||||||
uses: peter-evans/create-pull-request@v3
|
uses: peter-evans/create-pull-request@v3
|
||||||
with:
|
with:
|
||||||
branch: ${{ format('build/{0}', github.head_ref) }}
|
branch: ${{ format('build/{0}', github.head_ref) }}
|
||||||
|
base: 'develop'
|
||||||
commit-message: 'Built new icons, icomoon.json and devicon.css'
|
commit-message: 'Built new icons, icomoon.json and devicon.css'
|
||||||
title: 'bot:build new icons, icomoon.json and devicon.css'
|
title: 'bot:build new icons, icomoon.json and devicon.css'
|
||||||
body: 'Automated font-building task ran by GitHub Actions bot'
|
body: 'Automated font-building task ran by GitHub Actions bot'
|
||||||
delete-branch: ${{true}}
|
delete-branch: true
|
||||||
|
@@ -26,9 +26,8 @@ First of all, thanks for taking the time to contribute! This project can only gr
|
|||||||
<li>Include the name of the icon in the pull request title. Follow this format: <code>new icon: {{logoName}} ({{versions}})</code> </li>
|
<li>Include the name of the icon in the pull request title. Follow this format: <code>new icon: {{logoName}} ({{versions}})</code> </li>
|
||||||
<li><i>Optional</i>: Add images of the new icon(s) to the description of the pull request. This would help speed up the review process </li>
|
<li><i>Optional</i>: Add images of the new icon(s) to the description of the pull request. This would help speed up the review process </li>
|
||||||
<li><i>Optional</i>: Reference the issues regarding the new icon. </li>
|
<li><i>Optional</i>: Reference the issues regarding the new icon. </li>
|
||||||
<li>Wait for a repo maintainer to review your changes. Once they are satisfied, they will <a href="#buildScript">build your repo </a>. This will create a PR into your branch.</li>
|
<li>Wait for a repo maintainer to review your changes. They will run a script to check your icons. </li>
|
||||||
<li>Review the PR. It should contain the icon versions of your svgs. Accept the changes if you are satisfied</li>
|
<li>If there are no issue, they will accept your PR into the repo. Else, they will let you know and give you a chance to fix it.</li>
|
||||||
<li>Once you accept the changes, a maintainer will accept your PR into the repo.</li>
|
|
||||||
</ol>
|
</ol>
|
||||||
|
|
||||||
<hr>
|
<hr>
|
||||||
@@ -233,9 +232,13 @@ As an example, let's assume you have created the svgs for Amazon Web Services an
|
|||||||
<hr>
|
<hr>
|
||||||
<h2 id='buildScript'>Regarding The Build Script</h2>
|
<h2 id='buildScript'>Regarding The Build Script</h2>
|
||||||
<p>To make adding icons easier for repo maintainers, we rely on GitHub Actions, Python, Selenium, and Gulp to automate our tasks.</p>
|
<p>To make adding icons easier for repo maintainers, we rely on GitHub Actions, Python, Selenium, and Gulp to automate our tasks.</p>
|
||||||
<p>So far, the tasks that we have automated are:</p>
|
<p>So far, the tasks in the build script are:</p>
|
||||||
<ul>
|
<ul>
|
||||||
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and get the icons back. For details, see <a href="https://github.com/devicons/devicon/issues/252"> the original disscussion</a>, <a href="https://github.com/devicons/devicon/pull/268">this PR that introduce the feature</a> and <a href="https://github.com/devicons/devicon/issues/300">the final changes to it.</a></li>
|
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and get the icons back. For details, see <a href="https://github.com/devicons/devicon/issues/252"> the original disscussion</a>, <a href="https://github.com/devicons/devicon/pull/268">this PR that introduce the feature</a> and <a href="https://github.com/devicons/devicon/issues/300">the final changes to it.</a></li>
|
||||||
<li>Build, combine, and minify CSS files. For details, see <a href="https://github.com/devicons/devicon/pull/290">this</a></li>
|
<li>Build, combine, and minify CSS files. For details, see <a href="https://github.com/devicons/devicon/pull/290">this</a></li>
|
||||||
<li>Ensure code quality is up to standard</li>
|
</ul>
|
||||||
|
<p>There are also other tasks that we are automating, such as:</p>
|
||||||
|
<ul>
|
||||||
|
<li>Ensure code quality is up to standard</li>
|
||||||
|
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and take a screenshot for check.
|
||||||
</ul>
|
</ul>
|
Reference in New Issue
Block a user