From e51fb1ccd82a4a2cab87b707bd7e42d911e80faa Mon Sep 17 00:00:00 2001 From: Thomas Bui Date: Wed, 30 Dec 2020 11:20:25 -0800 Subject: [PATCH] Fixed error with logging --- .github/scripts/icomoon_peek.py | 18 +++++++++--------- .github/workflows/peek_icons.yml | 6 ++---- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/.github/scripts/icomoon_peek.py b/.github/scripts/icomoon_peek.py index e6d362f7..c5be4acf 100644 --- a/.github/scripts/icomoon_peek.py +++ b/.github/scripts/icomoon_peek.py @@ -16,19 +16,19 @@ def main(): # get only the icon object that has the name matching the pr title filtered_icons = find_object_added_in_this_pr(new_icons, args.pr_title) - # print list of new icons - print("List of new icons:", *new_icons, sep = "\n") - print("Icons being uploaded:", *filtered_icons, sep = "\n") - if len(new_icons) == 0: sys.exit("No files need to be uploaded. Ending script...") if len(filtered_icons) == 0: - sys.exit("No icons found matching the icon name in the PR's title.", - "Ensure that the PR title matches the convention here: ", - "https://github.com/devicons/devicon/blob/master/CONTRIBUTING.md#overview.", - "Ending script...", - sep='\n') + message = "No icons found matching the icon name in the PR's title.\n" \ + "Ensure that the PR title matches the convention here: \n" \ + "https://github.com/devicons/devicon/blob/master/CONTRIBUTING.md#overview.\n" \ + "Ending script...\n" + sys.exit(message) + + # print list of new icons + print("List of new icons:", *new_icons, sep = "\n") + print("Icons being uploaded:", *filtered_icons, sep = "\n", end='\n\n') runner = None try: diff --git a/.github/workflows/peek_icons.yml b/.github/workflows/peek_icons.yml index 398b62ee..140221fe 100644 --- a/.github/workflows/peek_icons.yml +++ b/.github/workflows/peek_icons.yml @@ -89,7 +89,6 @@ jobs: if: failure() uses: github-actions-up-and-running/pr-comment@v1.0.1 env: - OVERVIEW_IMG_URL: ${{ fromJSON(steps.icons_overview_img_step.outputs.imgur_urls)[0] }} MESSAGE: | Hi! @@ -103,12 +102,11 @@ jobs: Once everything is fixed, the maintainers will try again. If I still fail, the maintainers will investigate what cause this problem. - Thank you for your help :smile + Thank you for your help :smile: Cheers :), Peek Bot with: repo-token: ${{ secrets.GITHUB_TOKEN }} - message: ${{format(env.MESSAGE, env.OVERVIEW_IMG_URL, env.DETAILED_IMGS_MARKDOWN)}} - + message: ${{env.MESSAGE}}