From 00868081f624928d773a7b698654766f8cd70069 Mon Sep 17 00:00:00 2001 From: Vas Sudanagunta Date: Sun, 25 Feb 2018 01:15:03 -0500 Subject: [PATCH] Fix bug in Site.assembleSections method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Site.assembleSections logic assumes that the the home page would always be the first in the Site's list of pages. This is not in fact guaranteed to be true. When it is not, the method can fail to set the parent for some or all root-level pages. 
 Fixes #4447 --- hugolib/site_sections.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hugolib/site_sections.go b/hugolib/site_sections.go index 1a42f7808..5de350b2f 100644 --- a/hugolib/site_sections.go +++ b/hugolib/site_sections.go @@ -167,11 +167,15 @@ func (s *Site) assembleSections() Pages { undecided Pages ) + homes := s.findPagesByKind(KindHome) + if len(homes) == 1 { + home = homes[0] + } else if len(homes) > 1 { + panic("Too many homes") + } + for i, p := range s.Pages { if p.Kind != KindPage { - if p.Kind == KindHome { - home = p - } continue }