Clean up lint in various packages

Changes fall into one of the following:

- gofmt -s
- receiver name is inconsistent
- omit unused 2nd value from range
- godoc comment formed incorrectly
- err assigned and not used
- if block ends with a return statement followed by else
This commit is contained in:
Cameron Moore
2017-09-25 21:25:33 -05:00
committed by Bjørn Erik Pedersen
parent d45e358a05
commit 47fdfd5196
12 changed files with 44 additions and 42 deletions

View File

@@ -224,13 +224,13 @@ func TestHlLinesToRanges(t *testing.T) {
expected interface{}
}{
{"", 1, zero},
{"1 4", 1, [][2]int{[2]int{1, 1}, [2]int{4, 4}}},
{"1 4", 2, [][2]int{[2]int{2, 2}, [2]int{5, 5}}},
{"1-4 5-8", 1, [][2]int{[2]int{1, 4}, [2]int{5, 8}}},
{" 1 4 ", 1, [][2]int{[2]int{1, 1}, [2]int{4, 4}}},
{"1-4 5-8 ", 1, [][2]int{[2]int{1, 4}, [2]int{5, 8}}},
{"1-4 5", 1, [][2]int{[2]int{1, 4}, [2]int{5, 5}}},
{"4 5-9", 1, [][2]int{[2]int{4, 4}, [2]int{5, 9}}},
{"1 4", 1, [][2]int{{1, 1}, {4, 4}}},
{"1 4", 2, [][2]int{{2, 2}, {5, 5}}},
{"1-4 5-8", 1, [][2]int{{1, 4}, {5, 8}}},
{" 1 4 ", 1, [][2]int{{1, 1}, {4, 4}}},
{"1-4 5-8 ", 1, [][2]int{{1, 4}, {5, 8}}},
{"1-4 5", 1, [][2]int{{1, 4}, {5, 5}}},
{"4 5-9", 1, [][2]int{{4, 4}, {5, 9}}},
{" 1 -4 5 - 8 ", 1, true},
{"a b", 1, true},
} {