mirror/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2025-08-31 22:41:53 +02:00
Code Issues Packages Projects Releases Wiki Activity

commands: Deprecate --omitEmpty on chromastyles command

Browse Source 
It's no longer needed -- empty classes are now always omitted.

See  See 5b2a4c5a26
This commit is contained in:
Bjørn Erik Pedersen
2025-08-25 16:21:30 +02:00
parent c289fcaaaa
commit 61ec7a20a5
2 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
commands/gen.go
View File

@@ -82,13 +82,13 @@ See https://xyproto.github.io/splash/docs/all.html for a preview of the availabl
return err return err
} }
var options []html.Option
if omitEmpty { if omitEmpty {
options = append(options, html.WithClasses(true)) // See https://github.com/alecthomas/chroma/commit/5b2a4c5a26c503c79bc86ba3c4ae5b330028bd3d
} else { hugo.Deprecate("--omitEmpty", "Flag is no longer needed, empty classes are now always omitted.", "v0.149.0")
options = append(options, html.WithAllClasses(true)) }
options := []html.Option{
html.WithCSSComments(!omitClassComments),
} }
options = append(options, html.WithCSSComments(!omitClassComments))
formatter := html.New(options...) formatter := html.New(options...)
w := os.Stdout w := os.Stdout
@@ -106,7 +106,7 @@ See https://xyproto.github.io/splash/docs/all.html for a preview of the availabl
_ = cmd.RegisterFlagCompletionFunc("lineNumbersInlineStyle", cobra.NoFileCompletions) _ = cmd.RegisterFlagCompletionFunc("lineNumbersInlineStyle", cobra.NoFileCompletions)
cmd.PersistentFlags().StringVar(&lineNumbersTableStyle, "lineNumbersTableStyle", "", `foreground and background colors for table line numbers, e.g. --lineNumbersTableStyle "#fff000 bg:#000fff"`) cmd.PersistentFlags().StringVar(&lineNumbersTableStyle, "lineNumbersTableStyle", "", `foreground and background colors for table line numbers, e.g. --lineNumbersTableStyle "#fff000 bg:#000fff"`)
_ = cmd.RegisterFlagCompletionFunc("lineNumbersTableStyle", cobra.NoFileCompletions) _ = cmd.RegisterFlagCompletionFunc("lineNumbersTableStyle", cobra.NoFileCompletions)
cmd.PersistentFlags().BoolVar(&omitEmpty, "omitEmpty", false, `omit empty CSS rules`) cmd.PersistentFlags().BoolVar(&omitEmpty, "omitEmpty", false, `omit empty CSS rules (deprecated, no longer needed)`)
_ = cmd.RegisterFlagCompletionFunc("omitEmpty", cobra.NoFileCompletions) _ = cmd.RegisterFlagCompletionFunc("omitEmpty", cobra.NoFileCompletions)
cmd.PersistentFlags().BoolVar(&omitClassComments, "omitClassComments", false, `omit CSS class comment prefixes in the generated CSS`) cmd.PersistentFlags().BoolVar(&omitClassComments, "omitClassComments", false, `omit CSS class comment prefixes in the generated CSS`)
_ = cmd.RegisterFlagCompletionFunc("omitClassComments", cobra.NoFileCompletions) _ = cmd.RegisterFlagCompletionFunc("omitClassComments", cobra.NoFileCompletions)

15
testscripts/commands/gen.txt
View File

@@ -15,8 +15,15 @@ stdout 'Generated using: hugo gen chromastyles --style monokai'
! hugo gen chromastyles --style __invalid_style__ ! hugo gen chromastyles --style __invalid_style__
stderr 'invalid style: __invalid_style__' stderr 'invalid style: __invalid_style__'
# Issue 13475 # Not empty classes.
# From Hugo 0.149.0 empty classes are always removed, so no need for the omitEmpty flag.
hugo gen chromastyles --style monokai hugo gen chromastyles --style monokai
stdout '{ }' ! stdout '{ }'
hugo gen chromastyles --omitEmpty --style monokai hugo gen chromastyles --omitEmpty --style monokai --logLevel info
! stdout '\{ \}' stderr 'INFO deprecated: --omitEmpty was deprecated'
# Disable class comments.
hugo gen chromastyles --style monokai
stdout 'GenericSubheading'
hugo gen chromastyles --omitClassComments --style monokai
! stdout 'GenericSubheading'