Resolve error handling/parser related TODOs

See #5324
This commit is contained in:
Bjørn Erik Pedersen
2018-10-23 14:37:09 +02:00
parent f669ef6bec
commit 6636cf1bea
14 changed files with 67 additions and 68 deletions

View File

@@ -120,7 +120,6 @@ func (ns *Namespace) GetJSON(urlParts ...string) (v interface{}, err error) {
if err != nil {
return nil, _errors.Wrapf(err, "failed to get getJSON resource %q", url)
return nil, nil
}
return
}

View File

@@ -179,7 +179,7 @@ func (t *TemplateAdapter) addFileContext(name string, inerr error) error {
}
return false
}
// TODO(bep) 2errors text vs HTML
fe, ok := herrors.WithFileContext(ferr, realFilename, f, lineMatcher)
if ok || !hasMaster {
return fe