mirror of
https://github.com/gohugoio/hugo.git
synced 2025-08-28 22:19:59 +02:00
tpl: Fix internal templates usage of safeHTMLAttr
The `safeHTMLAttr` function operates on a full attribute definition, not just within the attribute value. Docs: https://gohugo.io/functions/safehtmlattr/ For `opengraph.html`, run the whole `content` HTML attribute through `safeHTMLAttr`. That will preserve `+` signs in formatted dates. For `vimeo_simple.html`, `safeHTMLAttr` was in the context of an attribute value, thus having no effect. In this case we could replace it with `safeURL`, but since the code is coming from an API it is safer to just let Go's template engine sanitize the value as it already does with `provider_url`. Fixes #5236 (no need to change Go upstream) Related to #5246
This commit is contained in:
committed by
Bjørn Erik Pedersen
parent
71b8d8b6a4
commit
e22b3f54c3
@@ -10,7 +10,7 @@
|
||||
{{ $secondClass := "s_video_simple" }}
|
||||
<div class="{{ $secondClass }} {{ $class }}">
|
||||
{{- with $item }}
|
||||
<a href="{{ .provider_url }}{{ .video_id | safeHTMLAttr }}" target="_blank">
|
||||
<a href="{{ .provider_url }}{{ .video_id }}" target="_blank">
|
||||
{{ $thumb := .thumbnail_url }}
|
||||
{{ $original := $thumb | replaceRE "(_.*\\.)" "." }}
|
||||
<img src="{{ $thumb }}" srcset="{{ $thumb }} 1x, {{ $original }} 2x" alt="{{ .title }}">
|
||||
|
Reference in New Issue
Block a user