From cbec1cdf3f8d8e4c7eff2db4eedfd40f6cfce6f4 Mon Sep 17 00:00:00 2001 From: diarmuid Date: Sat, 15 Aug 2015 18:29:50 +0100 Subject: [PATCH 1/2] Check for empty string --- src/Intervention/Image/Image.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Intervention/Image/Image.php b/src/Intervention/Image/Image.php index 5d4e170d..c24c41d7 100644 --- a/src/Intervention/Image/Image.php +++ b/src/Intervention/Image/Image.php @@ -268,7 +268,7 @@ class Image extends File */ public function isEncoded() { - return ! is_null($this->encoded); + return ! empty($this->encoded); } /** From 005c563112972968f9710fb2e911f35e287b3b00 Mon Sep 17 00:00:00 2001 From: diarmuid Date: Sat, 15 Aug 2015 18:30:10 +0100 Subject: [PATCH 2/2] Unit test isEncoded() function --- tests/ImageTest.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/ImageTest.php b/tests/ImageTest.php index ee76473a..752b0cc6 100644 --- a/tests/ImageTest.php +++ b/tests/ImageTest.php @@ -43,6 +43,15 @@ class ImageTest extends PHPUnit_Framework_TestCase @unlink($save_as); } + public function testIsEncoded() + { + $image = $this->getTestImage(); + $this->assertFalse($image->isEncoded()); + + $image->setEncoded('foo'); + $this->assertTrue($image->isEncoded()); + } + public function testFilter() { $demoFilter = Mockery::mock('\Intervention\Image\Filters\DemoFilter', array(15));