mirror/intervention_image
1
0
Fork 0
mirror of https://github.com/Intervention/image.git synced 2025-08-05 05:17:26 +02:00
Code Issues Releases Wiki Activity

Image ImageManager instantiation signature

Browse Source
This commit is contained in:
Oliver Vogel
2023-10-21 11:13:08 +02:00
parent 0bc8b7ce9b
commit f0e7abb56b
3 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Exceptions/ConfigurationException.php Normal file
View File

@@ -0,0 +1,8 @@
<?php
namespace Intervention\Image\Exceptions;
class ConfigurationException extends \RuntimeException
{
//
}

13
src/ImageManager.php
View File

@@ -9,9 +9,16 @@ class ImageManager
{ {
use CanResolveDriverClass; use CanResolveDriverClass;
public function __construct(protected string $driver = 'gd') private static $required_options = ['driver'];
public function __construct(protected array $options)
{ {
// if (count(array_intersect(array_keys($options), self::$required_options)) != count(self::$required_options)) {
throw new Exceptions\ConfigurationException(
'The following attributes are required to initialize ImageManager: ' .
implode(', ', self::$required_options)
);
}
} }
/** /**
@@ -55,6 +62,6 @@ class ImageManager
*/ */
protected function getCurrentDriver(): string protected function getCurrentDriver(): string
{ {
return strtolower($this->driver); return strtolower($this->options['driver']);
} }
} }

17
tests/ImageManagerTest.php
View File

@@ -2,6 +2,7 @@
namespace Intervention\Image\Tests; namespace Intervention\Image\Tests;
use Intervention\Image\Exceptions\ConfigurationException;
use Intervention\Image\ImageManager; use Intervention\Image\ImageManager;
use Intervention\Image\Interfaces\ImageInterface; use Intervention\Image\Interfaces\ImageInterface;
@@ -12,14 +13,20 @@ class ImageManagerTest extends TestCase
{ {
public function testConstructor() public function testConstructor()
{ {
$manager = new ImageManager('foo'); $manager = new ImageManager(['driver' => 'gd']);
$this->assertInstanceOf(ImageManager::class, $manager); $this->assertInstanceOf(ImageManager::class, $manager);
$this->expectException(ConfigurationException::class);
$manager = new ImageManager([]);
$this->expectException(ConfigurationException::class);
$manager = new ImageManager(['foo' => 'bar']);
} }
/** @requires extension gd */ /** @requires extension gd */
public function testCreateGd() public function testCreateGd()
{ {
$manager = new ImageManager('gd'); $manager = new ImageManager(['driver' => 'gd']);
$image = $manager->create(5, 4); $image = $manager->create(5, 4);
$this->assertInstanceOf(ImageInterface::class, $image); $this->assertInstanceOf(ImageInterface::class, $image);
} }
@@ -27,7 +34,7 @@ class ImageManagerTest extends TestCase
/** @requires extension gd */ /** @requires extension gd */
public function testReadGd() public function testReadGd()
{ {
$manager = new ImageManager('gd'); $manager = new ImageManager(['driver' => 'gd']);
$image = $manager->read(__DIR__ . '/images/red.gif'); $image = $manager->read(__DIR__ . '/images/red.gif');
$this->assertInstanceOf(ImageInterface::class, $image); $this->assertInstanceOf(ImageInterface::class, $image);
} }
@@ -35,7 +42,7 @@ class ImageManagerTest extends TestCase
/** @requires extension imagick */ /** @requires extension imagick */
public function testCreateImagick() public function testCreateImagick()
{ {
$manager = new ImageManager('imagick'); $manager = new ImageManager(['driver' => 'imagick']);
$image = $manager->create(5, 4); $image = $manager->create(5, 4);
$this->assertInstanceOf(ImageInterface::class, $image); $this->assertInstanceOf(ImageInterface::class, $image);
} }
@@ -43,7 +50,7 @@ class ImageManagerTest extends TestCase
/** @requires extension imagick */ /** @requires extension imagick */
public function testReadImagick() public function testReadImagick()
{ {
$manager = new ImageManager('imagick'); $manager = new ImageManager(['driver' => 'imagick']);
$image = $manager->read(__DIR__ . '/images/red.gif'); $image = $manager->read(__DIR__ . '/images/red.gif');
$this->assertInstanceOf(ImageInterface::class, $image); $this->assertInstanceOf(ImageInterface::class, $image);
} }