diff --git a/src/Drivers/AbstractDecoder.php b/src/Drivers/AbstractDecoder.php index 480d5be8..dd0ef0a8 100644 --- a/src/Drivers/AbstractDecoder.php +++ b/src/Drivers/AbstractDecoder.php @@ -43,7 +43,7 @@ abstract class AbstractDecoder implements DecoderInterface } catch (Throwable) { try { // source might be file pointer - $source = $this->buildFilePointer($input); + $source = $this->buildFilePointerOrFail($input); } catch (RuntimeException) { return new Collection(); } diff --git a/src/Drivers/AbstractEncoder.php b/src/Drivers/AbstractEncoder.php index 747cdcbc..59ddd281 100644 --- a/src/Drivers/AbstractEncoder.php +++ b/src/Drivers/AbstractEncoder.php @@ -34,7 +34,7 @@ abstract class AbstractEncoder implements EncoderInterface */ protected function createEncodedImage(callable $callback, ?string $mediaType = null): EncodedImage { - $pointer = $this->buildFilePointer(); + $pointer = $this->buildFilePointerOrFail(); $callback($pointer); return is_string($mediaType) ? new EncodedImage($pointer, $mediaType) : new EncodedImage($pointer); diff --git a/src/File.php b/src/File.php index 1b7d0e98..b0750edc 100644 --- a/src/File.php +++ b/src/File.php @@ -27,7 +27,7 @@ class File implements FileInterface, Stringable */ public function __construct(mixed $data = null) { - $this->pointer = $this->buildFilePointer($data); + $this->pointer = $this->buildFilePointerOrFail($data); } /** diff --git a/src/Traits/CanBuildFilePointer.php b/src/Traits/CanBuildFilePointer.php index a442cca8..7c22d394 100644 --- a/src/Traits/CanBuildFilePointer.php +++ b/src/Traits/CanBuildFilePointer.php @@ -15,7 +15,7 @@ trait CanBuildFilePointer * @throws RuntimeException * @return resource */ - public function buildFilePointer(mixed $data = null) + public function buildFilePointerOrFail(mixed $data = null) { $buildPointerStrategy = match (true) { is_null($data) => fn(mixed $data) => fopen('php://temp', 'r+'), diff --git a/tests/Unit/Drivers/AbstractDecoderTest.php b/tests/Unit/Drivers/AbstractDecoderTest.php index 4297f2b3..ccb968fd 100644 --- a/tests/Unit/Drivers/AbstractDecoderTest.php +++ b/tests/Unit/Drivers/AbstractDecoderTest.php @@ -33,7 +33,7 @@ final class AbstractDecoderTest extends BaseTestCase $source = $this->getTestResourceData('exif.jpg'); $pointer = $this->getTestResourcePointer('exif.jpg'); $decoder = Mockery::mock(AbstractDecoder::class); - $decoder->shouldReceive('buildFilePointer')->with($source)->andReturn($pointer); + $decoder->shouldReceive('buildFilePointerOrFail')->with($source)->andReturn($pointer); $result = $decoder->extractExifData($source); $this->assertInstanceOf(CollectionInterface::class, $result); $this->assertEquals('Oliver Vogel', $result->get('IFD0.Artist'));